fix: compile BLE split DFU - #4
Open
colonelpanic8 wants to merge 1 commit into
Open
Conversation
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpdatePolicythrough the BLE central call chainWhy
Enabling BLE and
dfu_splittogether exposes two pre-existing compile failures:SPLIT_MESSAGE_MAX_SIZEto 271 bytes, but TrouBLE's derive-generated default initialization does not work for[u8; 271]dfu_splitadds anUpdatePolicyargument toPeripheralManager::new, but the BLE path did not forward itThis PR contains only those compile-enablement changes. The notification-readiness fix is stacked separately in #2.
Validation
RUST_MIN_STACK=16777216 cargo +1.97.0 clippy --bin peripheral --features rmk/dfu_rp,rmk/dfu_split -- -D warningsinexamples/use_rust/pi_pico_w_ble_splitsh scripts/format_all.sh --touchedgit diff --checkStacked on #3.