Implement static analysis linting#46
Closed
macintoshhelper wants to merge 1 commit intocommaai:masterfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabled create-react-app runtime linting and replaced it with Airbnb static code analysis linting.
Best used with VS Code + https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint , but should have wide compatibility with other code editors.
I've disabled linting for a large chunk of the existing code for now to allow for iterative clean up, don't want massive merge conflicts or bug introduction.
New script:
npm run lintto check the linting, and could later be integrated with a precommit hook or CI checks.There is a debate between using Prettier or ESLint, this PR is opinionated. I personally prefer ESLint, since it lets you override it nicely when you intend to do so, has less magic and is nicer for git diffs. There might be ways to integrate the two, but might be unstable and overkill for now.
fixes #43