Use standalone eslint with airbnb presets#51
Merged
chrisinajar merged 7 commits intomasterfrom Oct 6, 2019
Merged
Conversation
Contributor
Author
|
the linting process is a WIP, but the configuration changes are done 👍 |
0xhsn
pushed a commit
to 0xhsn/connect
that referenced
this pull request
Feb 15, 2025
* Add eslint * Finish installing dependencies * eslint . --fix * Fix a bunch of eslint errors, 1.3k more * More linting * More linting * keep_fnames = true
LouisVelez
pushed a commit
to LouisVelez/new-connect
that referenced
this pull request
Jul 12, 2025
last part of commaai/connect#51 handles device disconnected, no items in queue, and rendering a list of files being uploaded possible features to add in the future: - nice animations - displaying the offline queue - simplify the polling loop with something like https://tanstack.com/query/latest/docs/framework/solid/overview
LouisVelez
pushed a commit
to LouisVelez/new-connect
that referenced
this pull request
Jul 12, 2025
commaai/connect#51 tested locally: 1. when device offline, upload request puts items in offline queue, showing them in the queue in the UI with a "Queued" message 2. when device comes online, status switches to "Waiting" until Athena server pushes the queued requests 3. finally, messages start coming in and processing as normal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using #46 as a template to redo the work. The build system changed and there were some conflicts, this seemed easier.