Skip to content

fix: clamp timeline drag selection to 1s minimum #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sshane wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: clamp timeline drag selection to 1s minimum #593

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/components/Timeline/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,14 @@ class Timeline extends Component {
const rulerBounds = this.rulerRef.current.getBoundingClientRect();
const startPercent = (Math.min(dragging[0], dragging[1]) - rulerBounds.x) / rulerBounds.width;
const endPercent = (Math.max(dragging[0], dragging[1]) - rulerBounds.x) / rulerBounds.width;
const startOffset = Math.round(this.percentToOffset(startPercent));
const endOffset = Math.round(this.percentToOffset(endPercent));
// Round to whole seconds (URL precision) so the section bounds match what we
// serialize, and so any drag is at least 1s wide. No separate sub-second
// internal state to keep in sync.
const startOffset = Math.round(this.percentToOffset(startPercent) / 1000) * 1000;
let endOffset = Math.round(this.percentToOffset(endPercent) / 1000) * 1000;
if (endOffset <= startOffset) {
endOffset = startOffset + 1000;
}

if (Math.abs(dragging[1] - dragging[0]) > 3) {
const offset = currentOffset();
Expand Down
Loading