Skip to content

Reset CANFD auto-detection on CAN init#2271

Merged
adeebshihadeh merged 4 commits intomasterfrom
reset-canfd
Sep 15, 2025
Merged

Reset CANFD auto-detection on CAN init#2271
adeebshihadeh merged 4 commits intomasterfrom
reset-canfd

Conversation

@adeebshihadeh
Copy link
Copy Markdown
Contributor

Resolves #2256

Copy link
Copy Markdown
Collaborator

@jyoung8607 jyoung8607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we're now picking up VIN and OBD firmware on a CAN-FD Honda Pilot.

9662a1dab70c9dc3/0000001b--d4a8e2dcf4

@adeebshihadeh adeebshihadeh merged commit 1289337 into master Sep 15, 2025
5 of 6 checks passed
@adeebshihadeh adeebshihadeh deleted the reset-canfd branch September 15, 2025 16:07
heysenbug pushed a commit to Ever-Cars/panda that referenced this pull request Oct 8, 2025
* Reset CANFD auto-detection on CAN init

* 4u

* simpler, 4th is fake
heysenbug added a commit to Ever-Cars/panda that referenced this pull request Oct 8, 2025
* jenkins: tmp disable bootkick tests

hardware needs to be fixed up

* flashing speeeed (commaai#2264)

* less sectors

* why are we taking baby steps

* revert

* cleanup

---------

Co-authored-by: Comma Device <device@comma.ai>

* optimize CAN send over SPI (commaai#2266)

* profiling

* lil faster

* chunking happens later

* little better

* prealloc is no bueno?

* cleanup

* fix usb tests

---------

Co-authored-by: Comma Device <device@comma.ai>

* SPI: ensure slave is in a consistent state after failed transfer (commaai#2268)

* SPI: ensure slave is in a consistent state after failed transfer

* respect timeout

* swap

* clean that up

* remove whitelist

* warning

* limit attempts

---------

Co-authored-by: Comma Device <device@comma.ai>

* remove spi dfu spam test

* python/SPI: add optional single ioctl path (commaai#2262)

* single ioctl

* debug

* fix import

* cleanup

---------

Co-authored-by: Comma Device <device@comma.ai>

* cleanup panda connect (commaai#2274)

* remove bcd

* fix jungle

* why fallback??

* cleanup

* jenkins: use git commit to bust cache (commaai#2273)

* CAN driver cleanup (commaai#2276)

* it's all the same thing

* not live

* less macro

* lil more

* bool

* lil more

* Change PWM to 25kHz (commaai#2277)

* fix build with different root

* gate spi2

* Change fan to use pure pwm (commaai#2267)

* set cuatro fan settings

* set cuatro to use pure pwm

* use pwm on all boards

* remove fan max rpm configs, use pure pwm

* add comment about cooldown

* change max rpm in python side

* remove reference to max_fan_pwm in fan.h

* fully refactor fan configs into "has_fan"

* increase limits on fan test to 15% either way

* only tres for now

* doesn't matter

* not relevant anymore

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Reset CANFD auto-detection on CAN init (commaai#2271)

* Reset CANFD auto-detection on CAN init

* 4u

* simpler, 4th is fake

* spi: let err count overflow (commaai#2279)

* ci: re-enable all HITL tests (commaai#2280)

fan

* safety: move relay fault management (commaai#2281)

* safety: move relay fault management

* set it

* use CANPacket definition from opendbc

* add --upgrade to uv sync (commaai#2282)

* Update LED_PWM_POWER definition (commaai#2283)

Changed LED_PWM_POWER value from 5 to 2.

* Differential sound (commaai#2284)

real

* Remove spidev2 support from SPI implementation (commaai#2287)

* Remove spidev2 support from SPI implementation

Removed support for spidev2 and related transfer methods.

* Remove spidev2 from dependencies

Remove spidev2 dependency for Linux platform.

* fix infinite serial read (commaai#2290)

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: probablyanasian <43358667+probablyanasian@users.noreply.github.com>
Co-authored-by: Maxime Desroches <desroches.maxime@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

H7: transceiver should be reset when switching the OBD multiplex

2 participants