Merged
Conversation
- Adds the core type sync implementations - Adds some unit tests
….com/commercetools/commercetools-sync-java into 300-feature-type-sync # Conflicts: # docs/RELEASE_NOTES.md
300 type sync review
heshamMassoud
approved these changes
Dec 6, 2018
Contributor
|
Great work @ahmetoz! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds implementations for the type sync.
Description
Relevant Issues
#300
Note: This PR is equivalent of that PR. You can check old PR here
Note 2: Some related issues that already WIP (some of them are not directly related to type but it can help to know) and should be on different PR.
#197, #313, #330, #331, #329, #325
Todo
Tests
Documentation
Add Release Notes entry.