Skip to content

QQ plots w. confidence bands#118

Merged
espenhgn merged 7 commits intocomorment:mainfrom
ttfiliz:fix37
Jan 17, 2023
Merged

QQ plots w. confidence bands#118
espenhgn merged 7 commits intocomorment:mainfrom
ttfiliz:fix37

Conversation

@ttfiliz
Copy link
Contributor

@ttfiliz ttfiliz commented Jan 15, 2023

Fixes #37

Changes proposed in this pull request:

  • GWASTools is now used for qq plots instead of qqman
  • Added GWASTools package to r.sif

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

@espenhgn
Copy link
Contributor

Thanks @ttfiliz,
I don't know if your PR is ready for review yet. In either case, can you also update the CHANGELOG file with these changes?

@ttfiliz
Copy link
Contributor Author

ttfiliz commented Jan 16, 2023

Thank you @espenhgn,
I have updated the changelog file.

@espenhgn espenhgn changed the title Fix37 QQ plots w. confidence bands Jan 17, 2023
@espenhgn espenhgn self-requested a review January 17, 2023 08:48
@espenhgn espenhgn added the enhancement New feature or request label Jan 17, 2023
Need to exist tmp dir
@espenhgn espenhgn merged commit 267a245 into comorment:main Jan 17, 2023
@ttfiliz ttfiliz deleted the fix37 branch March 11, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

qq plot confidence band

2 participants