fix: update base image to nodejs-22-steamcmd-ubuntu-24.04 (fixes GLIBC restart loop) - #1
Merged
Merged
Conversation
RustDedicated now requires GLIBC >= 2.34 (2.32/2.33/2.35 for UnityPlayer.so), but the ubuntu-20.04 base only ships glibc 2.31. The server binary fails to load immediately after install, causing containers to exit and restart-loop forever. Mirrors upstream Didstopia/rust-server, which moved to the nodejs-22-steamcmd-ubuntu-24.04 base and dropped the stale package-lock files (regenerated by npm install at build time). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the container base image to Ubuntu 24.04 / Node.js 22 to resolve RustDedicated’s newer GLIBC requirements and stop restart-loop deployments, while also aligning the repo with upstream by removing Node lockfiles.
Changes:
- Bump Docker base image from
didstopia/base:nodejs-16-steamcmd-ubuntu-20.04todidstopia/base:nodejs-22-steamcmd-ubuntu-24.04. - Remove
package-lock.jsonfiles from the embedded Node helper apps (shutdown/restart/scheduler/heartbeat/rcon).
Reviewed changes
Copilot reviewed 1 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Dockerfile | Updates base image to Ubuntu 24.04 / Node 22 to satisfy GLIBC requirements. |
| shutdown_app/package-lock.json | Removes npm lockfile for shutdown helper app. |
| restart_app/package-lock.json | Removes npm lockfile for restart helper app. |
| scheduler_app/package-lock.json | Removes npm lockfile for scheduler helper app. |
| heartbeat_app/package-lock.json | Removes npm lockfile for heartbeat helper app. |
| rcon_app/package-lock.json | Removes npm lockfile for rcon helper app. |
Files not reviewed (5)
- heartbeat_app/package-lock.json: Generated file
- rcon_app/package-lock.json: Generated file
- restart_app/package-lock.json: Generated file
- scheduler_app/package-lock.json: Generated file
- shutdown_app/package-lock.json: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,4 +1,4 @@ | |||
| FROM didstopia/base:nodejs-16-steamcmd-ubuntu-20.04 | |||
| FROM didstopia/base:nodejs-22-steamcmd-ubuntu-24.04 | |||
…digest - Regenerate package-lock.json for all helper apps under node 22 instead of deleting them, and switch builds to npm ci for reproducible dependency resolution - Pin didstopia/base:nodejs-22-steamcmd-ubuntu-24.04 by manifest digest so rebuilds of the same commit get the same runtime (verified: image builds clean with these changes) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Owner
Author
|
Addressed both review comments in 041bd2d:
Verified the image builds cleanly with these changes. |
compscidr
added a commit
to compscidr/iac
that referenced
this pull request
Aug 3, 2026
The rust servers were disabled in ae1518c while they were broken. Root cause was the ghcr.io/compscidr/rust-server image being built on ubuntu 20.04 (glibc 2.31) while RustDedicated now requires glibc >= 2.34 — fixed in compscidr/rust-server#1 by moving to the ubuntu 24.04 base. Re-enabling the role so ansible manages the containers again and pulls the fixed image. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
compscidr
added a commit
to compscidr/iac
that referenced
this pull request
Aug 3, 2026
The rust servers were disabled in ae1518c while they were broken. Root cause was the ghcr.io/compscidr/rust-server image being built on ubuntu 20.04 (glibc 2.31) while RustDedicated now requires glibc >= 2.34 — fixed in compscidr/rust-server#1 by moving to the ubuntu 24.04 base. Re-enabling the role so ansible manages the containers again and pulls the fixed image. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
rust-weeklyandrust-monthlyon nas.local have been stuck in restart loops (7k+ and 21k+ restarts). Root cause from container logs:Facepunch's current RustDedicated build requires glibc >= 2.34, but the
nodejs-16-steamcmd-ubuntu-20.04base ships glibc 2.31. The server binary dies instantly after the (~6GB) steam install/validate, the start script exits, and theunless-stoppedrestart policy loops forever.Verified the fix:
ldd RustDedicatedinsideubuntu:24.04resolves all glibc symbols (onlyUnityPlayer.sounresolved, which is expected — it's loaded viaLD_LIBRARY_PATHat runtime).Change
didstopia/base:nodejs-22-steamcmd-ubuntu-24.04— same fix upstream Didstopia/rust-server made in May 2026package-lock.jsonfiles (also mirrors upstream);npm installregenerates them at build time under node 22Merging publishes a new
ghcr.io/compscidr/rust-server:latestvia the docker-publish workflow.🤖 Generated with Claude Code