Conversation
…ort sudo to V2 A denied V2 GraphQL request used to surface as the generic "Something went wrong!" crash page, and leaked internal app/model/field claims into the error message since CBACPermissionDenied carried no real message or extensions. Give it extensions.code/claims (superuser-only) instead, add a matching NOT_FOUND code for unguarded ObjectDoesNotExist, and branch on both in apolloClient so the frontend renders a translated forbidden()/notFound() page instead of crashing. Also port V1's superuser sudo override (sudo_view.py) to V2: a shared grant_sudo() plus a sudoCbac mutation let a superuser confirm a temporary CBAC entry from a /sudo page reached via the denial, mirroring 403.pug's confirm-then-grant flow rather than V1's own auto-grant. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A denied V2 GraphQL request used to surface as the generic "Something went
wrong!" crash page, and leaked internal app/model/field claims into the
error message since CBACPermissionDenied carried no real message or
extensions. Give it extensions.code/claims (superuser-only) instead, add a
matching NOT_FOUND code for unguarded ObjectDoesNotExist, and branch on both
in apolloClient so the frontend renders a translated forbidden()/notFound()
page instead of crashing.
Also port V1's superuser sudo override (sudo_view.py) to V2: a shared
grant_sudo() plus a sudoCbac mutation let a superuser confirm a temporary
CBAC entry from a /sudo page reached via the denial, mirroring 403.pug's
confirm-then-grant flow rather than V1's own auto-grant.
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com