Add core features section back to the homepage#577
Merged
Conversation
Signed-off-by: Taylor Silva <dev@taydev.net>
This new search bar does kinda suck. Searching for "get step" doesn't result in the "get step" page appearing first. The search appears to prioritize the last word and just ranks things weird overall. It's annoying. Our old search was better imo. Signed-off-by: Taylor Silva <dev@taydev.net>
Member
Author
|
I did make heavy use of Claude to make this PR. I made small changes to whatever it did. I'm not a HTML/CSS expert, so apologies if there's anything odd/weird about the setup here. The homepage is very much a one-off thing compared to the rest of the site, so I'm okay with letting the LLM do weird stuff here. Anyone is free to submit a follow up PR if they want to clean things up a bit. The homepage does work on mobile as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered (the background is static when scrolling, so ignore the white background partway down the page in this image):
I am not happy with the search functionality in mkdocs. It seems to prioritize the last word searched and give priority to pages with more content(?).
My test with search has been
get step, which returns the following:The get step page is the next result once you scroll down in the list. It was worse before, but I've excluded some pages from the search which slightly improved the results. There are limited configuration options for this feature and I'm not sure how best to configure it. Hopefully Zensical's new search feature is better. I see it will have a fuzzy search capability, which might be a better fit for us.
I will miss our old search bar.