fix: Update remaining legacy links and home page theming#578
Merged
Conversation
Contributor
Author
|
Guess it'd be beneficial to show Light Mode works as expected as well 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr
There were still some links on the examples pages that pointed to the legacy links. While they would've redirected, it's better to just have them as the real internal links. Additionally, the home page had a white background but the code didn't respect that leading to weird behaviour.
Links
All the examples pages had a bottom section to reference things like Tasks and Jobs but still pointed to the legacy URLs. Updates those to point to the internal documents so routing is done properly.
Home Page
Current (with #577)
When dark mode is enabled, the code blocks are dark against a light background not matching the rest of the site
Fix
By removing hardcoded coloring and setting the background of the feature-box to
var(--md-default-bg-color), we can see a more pleasing code block on background view that matches the rest of the site