Skip to content

Force siphash for 3.9#736

Merged
conda-forge-admin merged 12 commits intoconda-forge:3.9from
matthiasdiener:siphash-v2-3.9
Apr 10, 2025
Merged

Force siphash for 3.9#736
conda-forge-admin merged 12 commits intoconda-forge:3.9from
matthiasdiener:siphash-v2-3.9

Conversation

@matthiasdiener
Copy link
Copy Markdown
Contributor

@matthiasdiener matthiasdiener commented Oct 16, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@matthiasdiener matthiasdiener changed the title add test Force siphash for 3.9 Oct 16, 2024
@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@matthiasdiener
Copy link
Copy Markdown
Contributor Author

@conda-forge-admin, please rerender

@matthiasdiener matthiasdiener marked this pull request as ready for review October 16, 2024 04:35
@matthiasdiener matthiasdiener mentioned this pull request Oct 16, 2024
5 tasks
@matthiasdiener
Copy link
Copy Markdown
Contributor Author

This is ready for review.

@matthiasdiener
Copy link
Copy Markdown
Contributor Author

A gentle ping for a review @conda-forge/python

@matthiasdiener
Copy link
Copy Markdown
Contributor Author

Another gentle ping @conda-forge/python

@xhochy
Copy link
Copy Markdown
Member

xhochy commented Nov 28, 2024

@conda-forge-admin please rerender

@conda-forge-admin
Copy link
Copy Markdown
Contributor

conda-forge-admin commented Nov 28, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12755212698. Examine the logs at this URL for more detail.

@xhochy
Copy link
Copy Markdown
Member

xhochy commented Dec 5, 2024

@conda-forge-admin please rerender

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12176060694. Examine the logs at this URL for more detail.

@matthiasdiener
Copy link
Copy Markdown
Contributor Author

Another gentle ping for a review @conda-forge/python

@jakirkham
Copy link
Copy Markdown
Member

@conda-forge-admin , please re-rerender

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13934358491. Examine the logs at this URL for more detail.

@jakirkham
Copy link
Copy Markdown
Member

@conda-forge-admin , please relint

@conda-forge-admin
Copy link
Copy Markdown
Contributor

conda-forge-admin commented Mar 18, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14389904095. Examine the logs at this URL for more detail.

@jakirkham
Copy link
Copy Markdown
Member

Seeing errors like this on Windows CI:

D:\bld\python-split_1742335590860\work\Modules\_ctypes\cfield.c(1508,1): error C2099: initializer is not a constant [D:\bld\python-split_1742335590860\work\PCbuild\_ctypes.vcxproj]

Doesn't look like the changes in this PR would affect it. Maybe we can try merging in the latests upstream changes to see if that helps?

@jakirkham jakirkham closed this Mar 19, 2025
@jakirkham jakirkham reopened this Mar 19, 2025
@jakirkham
Copy link
Copy Markdown
Member

Closing and reopening so CI picks up the latest changes in the upstream branch

@schribl
Copy link
Copy Markdown

schribl commented Mar 31, 2025

@matthiasdiener @jakirkham I had similar compile issues on Windows for #776 so I did a test without any change in #778 and it still failed. So I assume this issue is similar.

Small update:
I did update #778 as I discoverd that libffi was updated. And with the downgrade of libffi 3.4.6 -> 3.4.2 the windows build works again. I would expect similar results for 3.9

@matthiasdiener
Copy link
Copy Markdown
Contributor Author

The compile issue seems to have been resolved.

Copy link
Copy Markdown
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matthias and Thomas! 🙏

Glad to hear we got this working

Had one minor comment below. After that think we can merge

Comment thread recipe/conda_build_config.yaml Outdated
Co-authored-by: jakirkham <jakirkham@gmail.com>
@matthiasdiener
Copy link
Copy Markdown
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14389909430. Examine the logs at this URL for more detail.

@jakirkham jakirkham added the automerge Merge the PR when CI passes label Apr 10, 2025
@jakirkham
Copy link
Copy Markdown
Member

Thank you for adding all these fixes (especially to such an old version of Python). Having consistency across them is very helpful for users! 🙏

Queued to automerge

@conda-forge-admin conda-forge-admin merged commit 4320893 into conda-forge:3.9 Apr 10, 2025
10 checks passed
@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed
  • rerender called: passed

Thus the PR was passing and merged! Have a great day!

@matthiasdiener matthiasdiener deleted the siphash-v2-3.9 branch April 10, 2025 21:21
@jakirkham
Copy link
Copy Markdown
Member

Ah when resolving conflicts we missed a build/number. Sorry about that 🤦‍♂️

In any event there was a Python 3.9 patch release just merged: #786

So this should get picked up with that rebuild

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Merge the PR when CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants