Force siphash for 3.9#736
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.10.15.19.09.52
|
This is ready for review. |
|
A gentle ping for a review @conda-forge/python |
|
Another gentle ping @conda-forge/python |
|
@conda-forge-admin please rerender |
…onda-forge-pinning 2024.11.28.16.32.05
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12755212698. Examine the logs at this URL for more detail. |
…onda-forge-pinning 2024.11.28.16.32.05
|
@conda-forge-admin please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12176060694. Examine the logs at this URL for more detail. |
|
Another gentle ping for a review @conda-forge/python |
|
@conda-forge-admin , please re-rerender |
|
Hi! This is the friendly automated conda-forge-linting service. I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13934358491. Examine the logs at this URL for more detail. |
|
@conda-forge-admin , please relint |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14389904095. Examine the logs at this URL for more detail. |
|
Seeing errors like this on Windows CI: Doesn't look like the changes in this PR would affect it. Maybe we can try merging in the latests upstream changes to see if that helps? |
|
Closing and reopening so CI picks up the latest changes in the upstream branch |
|
@matthiasdiener @jakirkham I had similar compile issues on Windows for #776 so I did a test without any change in #778 and it still failed. So I assume this issue is similar. Small update: |
|
The compile issue seems to have been resolved. |
jakirkham
left a comment
There was a problem hiding this comment.
Thanks Matthias and Thomas! 🙏
Glad to hear we got this working
Had one minor comment below. After that think we can merge
Co-authored-by: jakirkham <jakirkham@gmail.com>
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14389909430. Examine the logs at this URL for more detail. |
|
Thank you for adding all these fixes (especially to such an old version of Python). Having consistency across them is very helpful for users! 🙏 Queued to automerge |
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
|
Ah when resolving conflicts we missed a In any event there was a Python 3.9 patch release just merged: #786 So this should get picked up with that rebuild |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)