[3.10] Use older libffi as new is not working with 3.10 on windows#778
Merged
isuruf merged 3 commits intoconda-forge:3.10from Apr 3, 2025
Merged
[3.10] Use older libffi as new is not working with 3.10 on windows#778isuruf merged 3 commits intoconda-forge:3.10from
isuruf merged 3 commits intoconda-forge:3.10from
Conversation
Contributor
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14174385939. Examine the logs at this URL for more detail. |
7c725a0 to
5acb225
Compare
Author
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2025.03.29.16.49.46
Member
|
Thanks |
Author
|
Thanks a lot @isuruf, should I backport the changes (force older libffi version) to 3.9 to fix the Windows build? |
Member
|
Yes, let's backport to 3.9 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)While working on #776 I discovered that the windows build for 3.10 (and 3.9) does not work on windows anymore.
I did not really find the root cause, but I checked old build logs from CI and the only major diff I could find was the libffi version. So I tried downgrading the libffi version and this apparently fixes the build.
Open question is:
Should the Linux build also downgrade or should be different versions of libffi be used per OS?
Also the other question would be what is the proper fix. I could not yet identify the exact PR in the Python repo that would fix this.