Skip to content

[3.10] Use older libffi as new is not working with 3.10 on windows#778

Merged
isuruf merged 3 commits intoconda-forge:3.10from
schribl:3.10-win-compile
Apr 3, 2025
Merged

[3.10] Use older libffi as new is not working with 3.10 on windows#778
isuruf merged 3 commits intoconda-forge:3.10from
schribl:3.10-win-compile

Conversation

@schribl
Copy link
Copy Markdown

@schribl schribl commented Mar 31, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

While working on #776 I discovered that the windows build for 3.10 (and 3.9) does not work on windows anymore.

I did not really find the root cause, but I checked old build logs from CI and the only major diff I could find was the libffi version. So I tried downgrading the libffi version and this apparently fixes the build.

Open question is:
Should the Linux build also downgrade or should be different versions of libffi be used per OS?

Also the other question would be what is the proper fix. I could not yet identify the exact PR in the Python repo that would fix this.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

conda-forge-admin commented Mar 31, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14174385939. Examine the logs at this URL for more detail.

@schribl schribl mentioned this pull request Mar 31, 2025
5 tasks
@schribl schribl changed the title dummy bump [3.10] Use older libffi as new is not working with 3.10 on windows Mar 31, 2025
@schribl schribl marked this pull request as ready for review March 31, 2025 12:07
@schribl schribl mentioned this pull request Mar 31, 2025
4 tasks
@schribl
Copy link
Copy Markdown
Author

schribl commented Mar 31, 2025

@conda-forge-admin, please rerender

@isuruf isuruf merged commit f0f763b into conda-forge:3.10 Apr 3, 2025
9 checks passed
@isuruf
Copy link
Copy Markdown
Member

isuruf commented Apr 3, 2025

Thanks

@schribl
Copy link
Copy Markdown
Author

schribl commented Apr 3, 2025

Thanks a lot @isuruf, should I backport the changes (force older libffi version) to 3.9 to fix the Windows build?

@isuruf
Copy link
Copy Markdown
Member

isuruf commented Apr 8, 2025

Yes, let's backport to 3.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants