[NT-2874] iOS parity with RN and centralization of preview panel logic#236
Merged
Alex Freas (akfreas) merged 6 commits intomainfrom Apr 28, 2026
Merged
[NT-2874] iOS parity with RN and centralization of preview panel logic#236Alex Freas (akfreas) merged 6 commits intomainfrom
Alex Freas (akfreas) merged 6 commits intomainfrom
Conversation
Alex Freas (akfreas)
requested review from
Lotfi Anwar L Arif (Lotfi-Arif) and
Charles Hudson (phobetron)
as code owners
Alex Freas (akfreas)
changed the title
Alex Freas (akfreas)
changed the title
…k package and update RN preview implementation to use
Alex Freas (akfreas)
force-pushed
the
NT-2874-ios-parity-fixes
branch
from
078e678 to
1e49dd7
Compare
Collaborator
There was a problem hiding this comment.
Why aren't we importing types, instead of re-specifying them?
…enceEntryFields, OptimizationEntryFields, OptimizationConfig, and OptimizationType from optimization-api-schemas.
Alex Freas (akfreas)
requested a review
from François (Lp-Francois)
as a code owner
… point. Re-publishes PreviewOverrideManager, buildPreviewModel, and the Contentful entry mappers via core, drops the standalone @contentful/optimization-preview package, and switches the RN SDK and ios-jsc-bridge consumers over.
Charles Hudson (phobetron)
previously approved these changes
Apr 28, 2026
Collaborator
Charles Hudson (phobetron)
left a comment
Charles Hudson (phobetron)
left a comment
There was a problem hiding this comment.
We can shore up README documentation (ensuring consumers ignore internal preview-specific support) separately as part of one of my tickets I think.
…and trim the public core-sdk README to a short pointer, marking the entry point as internal-only plumbing for the first-party preview panels.
Charles Hudson (phobetron)
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves functionality critical to the preview panel implementations into a new
preview-sdkso that it can be shared between React Native and the JSCore implementations (iOS and Android). This allows us to keep a single implementation of the override and interceptor logic for all platforms.