[CORL-2349] Use translation keys for relayNetworkRequestError strings#3786
Merged
kodiakhq[bot] merged 4 commits intodevelopfrom Nov 18, 2021
Merged
[CORL-2349] Use translation keys for relayNetworkRequestError strings#3786kodiakhq[bot] merged 4 commits intodevelopfrom
kodiakhq[bot] merged 4 commits intodevelopfrom
Conversation
|
✔️ Deploy Preview for gallant-galileo-14878c canceled. 🔨 Explore the source changes: e1c0593 🔍 Inspect the deploy log: https://app.netlify.com/sites/gallant-galileo-14878c/deploys/6196718b49ad8800079d7996 |
kabeaty
approved these changes
Nov 17, 2021
Contributor
kabeaty
left a comment
There was a problem hiding this comment.
Looks good and works as expected! Left one small note on the translations file, but approved.
GitHub complained, so I updated it.
Also fix typo in error message
5da81c7 to
80f48ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use translation keys to get error message text for the
RelayNetworkRequestErrordefined insrc/core/client/framework/lib/errors/relayNetworkRequestError.ts.What changes to the GraphQL/Database Schema does this PR introduce?
None
How do I test this PR?
Put the following after line 14 in your
customErrorMiddleware:Import
getMessagefromi18nincustomErrorMiddlewarevia:Have any error throw client side and see that the console shows the
LOOK HEREtranslation as translated correctly fromcommon.ftlwithAn unexpected network error occured, please try again later.and is not using the textTHIS FAILED AND USED DEFAULT.How do we deploy this PR?
N/A