Release 0.7.0 #64
Merged
Release 0.7.0 #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For parsing all the existing alternatives of an RCV CSV file for "Compra" (purchase), add these functions and their corresponding schemas: - `parse_rcv_compra_registro_csv_file`: "Registro" - `parse_rcv_compra_no_incluir_csv_file`: "No incluir" - `parse_rcv_compra_reclamado_csv_file`: "Reclamado" - `parse_rcv_compra_pendiente_csv_file`: "Pendiente" The implementations are very similar to `parse_rcv_venta_csv_file` (added in PR #52, commit c4fbfc1) and its interface is very different to the old `process_rcv_csv_file` (among other things, instead of calling a given handler on each row it yields the row), which will be removed. Tests have not been implemented.
And its related code. Its name was inappropriate because it supported only an specific kind of RCV CSV file: RCV "Compra/Registro" CSV file. Also, the implementation was not very good.
…X_csv_file rcv.parse_csv: add `parse_rcv_compra_X_csv_file`
Reference it from `base.constants` instead.
Move from `dte.data_models` and rename. Tests not yet implemented.
Tests not yet implemented.
libs.tz_utils: misc
Marshmallow field for RCV's "tipo documento".
…nstants rcv: add data models, constants and more
Include functions: - `with_mode_binary` - `with_mode_text` - `with_encoding_utf8`
libs: add module `io_utils`
- Now they yield dataclass `RcvDetalleEntry` instances instead of
dataclass `DteDataL2` instances.
- Params `{emisor, receptor}_{rut, razon_social}` renamed to `rut`
and `razon_social` respectively.
- `parse_rcv_venta_csv_file`: fields `Fecha Acuse Recibo` and
`Fecha Reclamo` are not ignored anymore.
- Marshmallow schemas' field `tipo_dte` replaced by `tipo_docto`.
- Marshmallow schemas' method `to_dte_data_l2` replaced by
`to_detalle_entry`.
…ions rcv.parse_csv: significant changes to parse functions
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
- Coverage 67.54% 64.75% -2.79%
==========================================
Files 20 22 +2
Lines 1026 1413 +387
Branches 154 205 +51
==========================================
+ Hits 693 915 +222
- Misses 286 450 +164
- Partials 47 48 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io_utils#62, 2019-06-13) libs: add moduleio_utilsparse_rcv_compra_X_csv_file#59, 2019-05-31) rcv.parse_csv: addparse_rcv_compra_X_csv_file