Skip to content

chore(charls): update CharLS submodule to upstream 2.4.4#77

Open
sedghi wants to merge 1 commit into
mainfrom
chore/charls-submodule-2.4.4
Open

chore(charls): update CharLS submodule to upstream 2.4.4#77
sedghi wants to merge 1 commit into
mainfrom
chore/charls-submodule-2.4.4

Conversation

@sedghi

@sedghi sedghi commented Jul 9, 2026

Copy link
Copy Markdown
Member

Second of the codec submodule upgrades (after openjph #76).

Bumps packages/charls/extern/charls from 38d95d0 (~2.4.1-era, Jan 2023) to upstream CharLS 2.4.4 (2026-06-08). Fork PR: cornerstonejs/charls#1.

  • No custom patches — the fork had zero divergence from upstream, so this is a clean version advance (unlike openjph, which needed carry/drop).
  • charls does not have the Debug-build issue openjph had (its build.sh builds optimized; shipped wasm is a healthy ~242 KiB).

CI validates: does 2.4.4 compile against our charls glue (API drift over ~3.5y), do the pixel-correctness goldens still pass byte-identically, and dist-size. Not built locally; iterating on CI. Not for merge yet.

Advances from 38d95d0 (~2.4.1-era, Jan 2023) to upstream 2.4.4 (2026-06-08).
No custom fork patches (clean version advance). Fork PR: cornerstonejs/charls#1.
CI is the first build/validation of 2.4.4 against our glue.
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@sedghi, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 849b3c00-4351-48d4-9f2a-8b3e5427b7fe

📥 Commits

Reviewing files that changed from the base of the PR and between 9c086c9 and 68d6f90.

📒 Files selected for processing (1)
  • packages/charls/extern/charls
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/charls-submodule-2.4.4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codspeed-hq

codspeed-hq Bot commented Jul 9, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 57.25%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 19 untouched benchmarks
⏩ 99 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation decode CT-512x512-near-lossless.JLS (.81 near-lossless) — cold 19.8 ms 46.3 ms -57.25%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing chore/charls-submodule-2.4.4 (68d6f90) with main (a88a461)2

Open in CodSpeed

Footnotes

  1. 99 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (9c086c9) during the generation of this report, so a88a461 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@sedghi

sedghi commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

Status: green except one CodSpeed gate = known CPU-lottery noise

charls 2.4.4 (from ~2.4.1-era). All real checks pass: build, test, browser-smoke, dist-size, codspeed-bench, codspeed-walltime. No build fixes and no glue changes were needed — the fork had zero divergence, so this is a clean version advance.

The one red — CodSpeed Performance Analysis — is not a real regression. CodSpeed's own "Environment Differences" section attributes it to a runner CPU change (AMD EPYC 7763 → 9V74) on one near-lossless .81 — cold Simulation bench; the warm variant is unchanged, WallTime is unaffected, and 19/20 benches are unchanged. Decode output is byte-identical (goldens pass).

Fork PR: cornerstonejs/charls#1 — MERGEABLE. No custom patches (clean advance).

Actions to merge

  1. Merge fork charls#1.
  2. Acknowledge the single noise bench on the CodSpeed dashboard (or rely on the self-hosted-runner change in ci(codspeed): move the simulation bench gate to a dedicated self-hosted runner #75 to remove this class of noise).
  3. Merge this PR. No code changes required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant