IBC custom app draft #1182
IBC custom app draft #1182
Conversation
tmsdkeys
requested review from
8bitpal,
coldice,
gioelebonifetto and
xavierlepretre
as code owners
charleenfei
left a comment
charleenfei
left a comment
There was a problem hiding this comment.
super nice job @tmsdkeys!!
i just left a few minor spelling corrections, as well as a few content suggestions that are not blockers from my side but nice to have. overall great job, really easy to follow and nicely articulated!
academy/ibc-dev/ibcapp_packet.md
Outdated
|
|
||
| We can thus send packets from the CLI with the following command: | ||
| ```bash | ||
| leaderboardd tx leaderboard send-ibcTopRank [portID] [channelID] [playerId] [rank] [score] |
There was a problem hiding this comment.
Should it not be only "leaderboard tx leaderboard send-ibcTopRank [portID] [channelID] [playerId]" where the rank and the score are fetched from the store instead of being cli arguments so one cannot send arbitrary rank or score?
Spelling corrections Co-authored-by: Xavier Leprêtre <xavierlepretre@users.noreply.github.com> Co-authored-by: Charly <charly@interchain.berlin>
|
Thanks @AndrewB9lab for the language review (I gave you quite some work using first person plural in most of it)! Left a few comments which I can implement |
|
@tmsdkeys only just saw your last message - I've now implemented your comments :-) |
|
@CitMC agree to the style changes 👍 |
Documentation content update for IBC dev - IBC custom apps
This PR adds new IBC related content for the 2nd cohort of IDA. It adds the section on IBC custom applications, using Ignite CLI and comparing changes across commits with the IBC go docs.
Notes for reviewers: Focused on content initially, still some images, links need to be inserted. Language checks will be provided post content review, so best not to focus too much on that
Change scope
The changes in this Pull Request include (please tick all that apply):
R1: Internal review (B9lab)
R2: External review
R3: Internal QA review (B9lab)
R4: Final external QA review
RC: Release Candidate