Fall back for failed asset thumbs#183
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a control panel–side fallback so that when a PDF thumbnail image fails to load (e.g., Cloud rasterization can’t produce an image), the UI swaps the broken thumbnail for the standard PDF icon instead of showing a broken image.
Changes:
- Introduces a new CP asset bundle that injects a global setting containing the PDF icon URL.
- Adds a small JS listener that detects failed PDF thumbnail loads and replaces the thumbnail with the PDF icon.
- Registers the new asset bundle for CP requests when the Asset CDN integration is enabled.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/web/assets/assetthumbfallback/webpack.config.js | Adds webpack build config for the new AssetThumbFallback bundle. |
| src/web/assets/assetthumbfallback/src/AssetThumbFallback.js | Implements the client-side error handler that swaps failed PDF thumbs to an icon. |
| src/web/assets/assetthumbfallback/dist/AssetThumbFallback.js.map | Adds compiled source map for the new JS asset. |
| src/web/assets/assetthumbfallback/dist/AssetThumbFallback.js | Adds compiled JS asset to be shipped/registered in the CP. |
| src/web/assets/assetthumbfallback/AssetThumbFallbackAsset.php | Defines the new CP asset bundle and injects the icon URL into window.Craft.CloudAssetThumbFallback. |
| src/Module.php | Registers the new asset bundle for CP requests (alongside the existing uploader bundle). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
timkelty
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeps the control panel from showing broken thumbnails when Cloud asset transforms cannot produce an image.