-
Notifications
You must be signed in to change notification settings - Fork 31
Documentation: Modernization and copy-editing #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6090d53 to
5dc0e04
Compare
f7b4252 to
a09ee15
Compare
e8effb4 to
8afd8a7
Compare
Improve wording, linking, and formatting.
8afd8a7 to
c1fd85c
Compare
docs/sqlalchemy.rst
Outdated
|
|
||
| In addition to the `Object`_ type, the CrateDB SQLAlchemy dialect also provides | ||
| a ``ObjectArray`` type, which is structured as a `list`_ of `dictionaries`_. | ||
| a ``ObjectArray`` type, which is structured as a :class:`py:list` of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's weird, thanks for spotting. I do not have an idea yet, why this is happening.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Observations I
<a class="reference external" href="https://docs.python.org/3/library/stdtypes.html#list" title="(in Python v3.11)">
<code class="docutils literal notranslate">
<span class="pre">list</span>
</code>
</a><a class="reference external" href="https://docs.python.org/3/library/stdtypes.html#dict" title="(in Python v3.11)">
<code class="xref py py-class docutils literal notranslate">
<span class="pre">dictionaries</span>
</code>
</a>It looks like the xref class (from basic.css) adds the font-weight: bold; CSS directive.
Observations II
Funny enough, when rendering locally (not on RTD), those additional code tags, including the corresponding classes, are not rendered at all. Instead, the HTML looks like this:
<a class="reference external" href="https://docs.python.org/3/library/stdtypes.html#lists">list</a>
<a class="reference external" href="https://docs.python.org/3/library/stdtypes.html#dict">dictionaries</a>And visually, it looks like this, which I think would be good.

Next steps
So, I guess we will need to find out why the HTML output is different when being built on/by RTD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After resetting my local sandbox environment, I am also getting the same results as above, where the rendered HTML at this spot includes <code> tags, and where the same CSS classes xref py py-class are present on the :class:dictionaries <py:dict> link.
It looks like the custom label, dictionaries, is responsible for the additonal xref py py-class classes, and xref makes the link label render in bold.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not been able to discover the root cause, so I fixed it with crate/crate-docs-theme#366.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
285dc2d to
c1d94b5
Compare



Some copy editing across the board, with a focus on wording, linking, and formatting.