Documentation: Improve guidance about migrating to sqlalchemy-cratedb
#636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
requested review from
hammerhead,
hlcianfagna,
matriv,
seut,
simonprickett and
surister
and removed request for
matriv and
seut
matriv
approved these changes
Jun 28, 2024
Contributor
matriv
left a comment
matriv
left a comment
There was a problem hiding this comment.
thx, left a suggestion (in 2 places).
LGTM, please wait for a look from another reviewer though, thx!
hlcianfagna
approved these changes
Jun 28, 2024
surister
approved these changes
Jun 28, 2024
Mention the switchover both on the project's README, and the index page of the documentation, in order to give users who might be running into relevant flaws a better chance to discover the solution. Co-authored-by: Marios Trivyzas <5058131+matriv@users.noreply.github.com>
amotl
force-pushed
the
amo/improve-sa-migration-docs
branch
from
3381cb1 to
4d61a4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Mention the switchover to
sqlalchemy-cratedbboth on the project's README, and the index page of the documentation, in order to give users who might be running into relevant flaws a better chance to discover the solution.Preview
References
sqlalchemy-cratedb#621/cc @seut, @matriv