Tests: Add software tests and CI/GHA configuration #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
testing-and-ci
branch
4 times, most recently
from
f5875b2 to
c3ba2f5
Compare
amotl
commented
Oct 30, 2024
Comment on lines
90
to
92
| if response["rowcount"] == 1: | ||
| print(f"Average temperature over last 24hrs: {response["rows"][0][0]}") | ||
| print(f"Average temperature over last 24hrs: {response['rows'][0][0]}") | ||
| num_iterations = 0 |
Member
Author
There was a problem hiding this comment.
That's a syntax error at least on CPython 3.7. I wonder why it is apparently not the same on either MicroPython or CPython 3.13.
amotl
force-pushed
the
testing-and-ci
branch
3 times, most recently
from
1cfaaa6 to
fe62c57
Compare
simonprickett
approved these changes
Oct 30, 2024
Contributor
simonprickett
left a comment
simonprickett
left a comment
There was a problem hiding this comment.
Looks good to me @amotl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Based on GH-23, this adds a a few bits of configuration to use the files in the "examples" folder as test cases. On top, a CI configuration using GHA will automate things well.
Status
Currently, it is still about CPython only. Enabling a MicroPython test matrix slot would still be up for another iteration.
Remarks
Please integrate the other patch first, because this one is stacked upon it.