Chore: Format code using Ruff. Satisfy and enable linter on CI. #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
commented
Oct 30, 2024
Comment on lines
57
to
+58
| - name: Run linters and software tests | ||
| run: poe test | ||
| run: poe check |
Member
Author
There was a problem hiding this comment.
NB/FYI: poe check invokes both poe lint and poe test, in this order. That verifies that the code is always in the right shape, and will never include obstacles, mostly introduced by accidents, for example stray print statements or such.
simonprickett
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
A little followup to GH-25, effectively activating the Ruff linter on CI, after formatting the code using
poe format, and applying a few manual adjustments.