fix(site): download page targets Electron release, auto-release desktop - #373
Merged
Conversation
The /download page fetched GitHub `releases/latest`, which returns the most recently published release across ALL tags — usually an npm package release (e.g. `@xnetjs/trust@x.y.z`) that carries no desktop assets — so every button fell back to the generic releases page. Fetch the release list and pick the newest non-draft `v<number>` tag (the desktop scheme) instead, and match assets by electron-builder's real names (bare-x64 vs `arm64`-suffixed; `.Setup.N.exe`). Desktop was also frozen at the 2026-03-05 `v0.0.1` build: electron-release.yml only publishes when `apps/electron/package.json`'s version is new, but it was pinned at 0.0.1, so every run since March was a ~10s no-op. Peg the desktop version to `@xnetjs/core` (anchor of the changeset `fixed` group) via scripts/changeset/sync-electron-version.mjs, wired into `version-packages`, so the bump rides the same "Version Packages" PR and merging cuts a matching `v<version>` release. Bump 0.0.1 -> 0.0.3 to unfreeze immediately. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: xNet Test <test@xnet.dev>
Contributor
|
✓ Changelog fragment found — thanks! |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: xNet Test <test@xnet.dev>
Contributor
|
Preview removed for PR #373. |
crs48
added a commit
that referenced
this pull request
Jul 4, 2026
The **"View release assets and checksums"** link at the bottom of [`/download`](https://xnet.fyi/download/) pointed at the generic `/releases` index, which interleaves npm-package releases (`@xnetjs/core@x.y.z`, `@xnetjs/trust@x.y.z`) with the desktop releases — so it didn't land on the build being offered. Now it deep-links to the specific desktop release tag already resolved for the download buttons (`/releases/tag/v<version>`), falling back to the index only if no desktop release resolves. Follow-up to #373. ## Testing Simulated the build-time resolution against the live GitHub API: link resolves to `https://github.com/crs48/xNet/releases/tag/v0.0.1` (the current newest desktop release; becomes `v0.0.3` once that build publishes and the site rebuilds). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
crs48
added a commit
that referenced
this pull request
Jul 4, 2026
…ll (#375) Follow-up to #373. The desktop auto-release ran a real (non-no-op) build for the first time since March and surfaced latent breakage on two platforms (macOS + Linux arm64 build clean; the `release` job needs all platforms, so nothing publishes until these are fixed). ## Windows — fixed `@electron/rebuild` runs with `buildFromSource=false`: `better-sqlite3` uses its downloaded Electron prebuild and finishes instantly, but **`usearch` and `sharp` have no Electron prebuild**, so they compile from source. GitHub's `windows-latest` now ships **Visual Studio 2026** (runner image `Windows2025-VS2026`), which the **node-gyp 9.4.1** bundled by `@electron/rebuild` is too old to detect → *"Could not find any Visual Studio installation to use."* That's exactly why the March build passed (windows-latest was VS 2022 then) and now fails. **Fix:** pin `build-windows` to the `windows-2022` image, whose VS 2022 node-gyp 9.4.1 detects. ## Linux x64 — instrumented for diagnosis The packaged app never opens a window (60s `firstWindow` timeout) and prints **zero output** — deterministic across two runs. Boot `await`s `spawnDataProcess()` (a `utilityProcess.fork` loading `better-sqlite3`) **before** `createWindow()`, so if that utility process doesn't signal ready on packaged Linux x64, the window is never created. macOS packaged and the unpackaged `electron-e2e` job both pass, so it's specific to the packaged Linux x64 combination. The app was silent because its data-process logging is gated behind an IPC toggle that needs a renderer (which never exists here), and the `whenReady` chain had no `.catch`. This PR makes the failure observable: - `data-process-manager.ts`: honor `XNET_DEBUG=1` at startup to emit the boot trace without a renderer. - `index.ts`: add a `.catch` on the `whenReady` chain so a pre-window boot failure logs to stderr instead of dying silently (a genuine robustness fix — users currently get a dead app with no clue). - smoke step runs with `XNET_DEBUG=1 E2E_DEBUG=1` so CI captures the real cause. After this lands I'll dispatch `electron-release` to confirm Windows goes green and read the Linux x64 boot trace, then land the precise Linux fix. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
3 tasks
crs48
added a commit
that referenced
this pull request
Jul 5, 2026
## Summary Implements exploration 0265: every `npm Release` run on main has failed since 2026-07-04 because `sync-electron-version.mjs` (PR #373) bumps `xnet-desktop` inside `pnpm version-packages`, and `changesets/action` then crashes with ENOENT reading the nonexistent `apps/electron/CHANGELOG.md` (changesets/action#256). The Version Packages PR #281 has been frozen since, and nothing can publish. - **fix(release):** the sync script now owns the desktop changelog — seeds `apps/electron/CHANGELOG.md` and prepends a matching `## <version>` entry on every core-train bump (idempotent; exported function + `node:test` coverage; verified end-to-end with a local `pnpm version-packages` run). - **ci(release):** a red `npm Release` run now opens (or comments on) a single deduped alarm issue instead of failing silently — 12 consecutive failures went unnoticed. - **docs:** release-cadence policy in `CLAUDE.md` (merge the refreshed Version Packages PR after each exploration lands; `.changeset/` pile-up is the stall litmus) + the 0265 exploration doc. Staged-bump audit: no majors pending; the fixed core group will release as **0.1.0** (minor) — appropriate for the queued changesets. ## Test plan - [x] `node --test scripts/changeset/sync-electron-version.test.mjs` (5 tests) - [x] Local `pnpm version-packages` repro: 0.0.3 → 0.1.0 bump writes the changelog entry, no ENOENT - [ ] Post-merge: next `npm Release` run on main goes green and refreshes PR #281 with the 0263/0264 changesets 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Two coupled fixes to the
/downloadpage and the desktop release pipeline.1. Download page linked to the wrong release
download.astrofetched GitHubreleases/latest, which returns the most-recently-published release across all tags — currently@xnetjs/trust@0.0.2, an npm-package release with zero desktop assets. So every platform button fell back to the generic releases page. Two asset patterns (x64.dmg,Setup.exe) also didn't match electron-builder's real filenames, so Intel-mac and Windows would break even against the right release.Fix: fetch the release list and select the newest non-draft release whose tag matches
v<number>(the desktop scheme), and match assets by electron-builder's real naming (bare-x64 vsarm64-suffixed,.Setup.N.exe). Simulated against the live GitHub API — all five buttons now resolve to realv0.0.1assets with zero fallbacks.2. Electron wasn't auto-releasing (frozen since 2026-03-05)
electron-release.ymlonly publishes whenapps/electron/package.json's version is new, but it was pinned at0.0.1. Every run since March finished in ~10s with all build jobs skipped — still green, which is why it looked healthy. Desktop users have been stuck on the March build.Fix (rides the core release train):
scripts/changeset/sync-electron-version.mjspegsxnet-desktop's version to@xnetjs/core(anchor of the changesetfixedgroup), wired intoversion-packagesso the bump lands in the same "Version Packages" PR.xnet-desktopisprivate+ in changesetignore, so changesets never versions it on its own — this script is the coupling. Bumped0.0.1 → 0.0.3here to unfreeze immediately: merging this cuts a freshv0.0.3desktop release built from currentmain, which the download page then serves.Tradeoff: a change touching only
apps/electron/**(no core changeset) won't trigger a desktop release, since the version won't move — inherent to the core-train approach.Testing
v0.0.1release selected, all 5 buttons resolve, no fallbacks.sync-electron-version.mjsverified:0.0.1 → 0.0.3and idempotent on re-run.🤖 Generated with Claude Code