fix(site): deep-link 'release assets' to the desktop release - #374
Merged
Conversation
The 'View release assets and checksums' link went to the generic /releases index, which mixes npm-package and desktop releases. Point it at the specific desktop release tag being offered (/releases/tag/v<version>), falling back to the index only when no desktop release resolves. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: xNet Test <test@xnet.dev>
Contributor
|
✓ Changelog fragment found — thanks! |
Contributor
|
Preview removed for PR #374. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "View release assets and checksums" link at the bottom of
/downloadpointed at the generic/releasesindex, which interleaves npm-package releases (@xnetjs/core@x.y.z,@xnetjs/trust@x.y.z) with the desktop releases — so it didn't land on the build being offered.Now it deep-links to the specific desktop release tag already resolved for the download buttons (
/releases/tag/v<version>), falling back to the index only if no desktop release resolves. Follow-up to #373.Testing
Simulated the build-time resolution against the live GitHub API: link resolves to
https://github.com/crs48/xNet/releases/tag/v0.0.1(the current newest desktop release; becomesv0.0.3once that build publishes and the site rebuilds).🤖 Generated with Claude Code