fix(ocm): honor env proxy in outbound client#5674
Merged
Merged
Conversation
MahdiBaghbani
requested review from
diocas,
glpatcern,
jessegeens and
rawe0
as code owners
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
MahdiBaghbani
force-pushed
the
feature/ocm-outbound-proxy-support
branch
from
28a8e0f to
68b9f7e
Compare
glpatcern
approved these changes
Jun 29, 2026
Tristan-C789
pushed a commit
to Tristan-C789/reva
that referenced
this pull request
Jul 2, 2026
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My primary use case for this is correctly route every OCM endpoint call through MITM and log it.
Other than that, I think it's generally a good practice to respect the system settings for the proxy in case of SOCKS5 or other tunneling settings like VPN.
WebDAV is using a library which correctly respects the system proxies, but the OCM client doesn't so in my case the WebDAV calls are logged but not the OCM calls.