Support double-precision data in reports; experiment with double-precision MTR data #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nealkruis
reviewed
Jul 10, 2023
| *p dbl bt // battery output (negative) | ||
| *e dbl pv // photovoltaic array output (negative) | ||
| *e dbl allEU // subtotal, clg .. usr2 (= load w/o bt and pv) | ||
| #else |
Contributor
There was a problem hiding this comment.
Do we want to keep Float around? Is there any reason not to remove it?
Contributor
Author
There was a problem hiding this comment.
The MTR data are now float due to #undef METER_DBL. I decided not to code out the conditional code until some conclusion(s) are reached on double precision policy.
However, it is worth noting that changing MTR to double resulted in only infinitesimal changes in reported results, even for complicated situations involving may accumulating items and multiple submeters with multipliers. Anecdotally, that strongly indicates float is good enough for our S -> H -> D -> M -> Y accumulation scheme. So maybe the matter is settled for accumulation at least.
nealkruis
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifications to built-in report generation machinery in cgresult.cpp provide support for double-precision data. The report scheme is table-driven with one row per report column. A new flag allows indicating that the data being accessed is double as opposed to float.
Improved generalized data access functions added to support that change.
Testing was performed by changing MTR end use data via conditional code controlled by METER_DBL (cndefns.h). Reported results were virtually identical to those with float data even for complex MTR schemes with submeters. METER_DBL left #undef'd but the conditional code retained for future experiments.
Test file submeter.cse updated to better test submeters with multipliers.