Skip to content

Support double-precision data in reports; experiment with double-precision MTR data #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Support double-precision data in reports; experiment with double-precision MTR data #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 45 additions & 1 deletion src/CNRECS.DEF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5441,8 +5441,45 @@ RECORD MTR_IVL "meter interval sub" *SUBSTRUCT // substruct for one meter for o
*declare "void mtr_Accum1( const MTR_IVL* mtrSub1, IVLCH ivl, int options=0);"
*declare "void mtr_AccumFromSubmeter( const MTR_IVL* subMtr, float mult);"
*declare "double mtr_NetBldgLoad() const;"
*declare "RC mtr_Validate( const MTR* mtr, IVLCH ivl) const;"
*declare "RC mtr_Validate1( const MTR* mtr, IVLCH ivl) const;"

#if defined( METER_DBL)

*p dbl tot // total of following specific end uses. Code assumes precedes them.
// = allEU + bt + pv
// Use by purpose (end use), energy used in Btu:
// CAUTION: order of members MATCHES DTENDUSECH choices (cndtypes.def)
// for subscripting (in cnguts,cgresult.cpp) by end use -1:
*e dbl clg // space cooling. code assumes 1st member.
*e dbl htg // space heating incl heat pump compressor
*e dbl hpBU // heat pump resistance heating (backup and defrost)
*e dbl dhw // domestic (service) hot water heating
// HPWH: compressor+misc energy
*e dbl dhwBU // domestic (service) hot water backup
// HPWH: resistance heating energy
// others: virtual backup to maintain ws_tUse
*e dbl dhwMFL // domestic (service) multi-family loop energy
// = DHWLOOP pump electricity + loss makeup
*e dbl fanC // fans - cooling and cooling ventilation
*e dbl fanH // fans - heating
*e dbl fanV // fans - IAQ ventilation
*e dbl fan // fans - other
*e dbl aux // HVAC auxiliaries and parasitics, not including fans
*e dbl proc // process energy
*e dbl lit // lighting
*e dbl rcp // receptacles
*e dbl ext // external -- outdoor lights, etc
*e dbl refr // refrigeration
*e dbl dish // dish washing
*e dbl dry // clothes drying
*e dbl wash // clothes washing
*e dbl cook // cooking
*e dbl usr1 // user-defined end use 1
*e dbl usr2 // user-defined end use 2
*p dbl bt // battery output (negative)
*e dbl pv // photovoltaic array output (negative)
*e dbl allEU // subtotal, clg .. usr2 (= load w/o bt and pv)
#else
Copy link
Contributor

@nealkruis nealkruis Jul 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to keep Float around? Is there any reason not to remove it?

Copy link
Contributor Author

@chipbarnaby chipbarnaby Jul 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MTR data are now float due to #undef METER_DBL. I decided not to code out the conditional code until some conclusion(s) are reached on double precision policy.

However, it is worth noting that changing MTR to double resulted in only infinitesimal changes in reported results, even for complicated situations involving may accumulating items and multiple submeters with multipliers. Anecdotally, that strongly indicates float is good enough for our S -> H -> D -> M -> Y accumulation scheme. So maybe the matter is settled for accumulation at least.

*p float tot // total of following specific end uses. Code assumes precedes them.
// = allEU + bt + pv
// Use by purpose (end use), energy used in Btu:
Expand Down Expand Up @@ -5477,6 +5514,9 @@ RECORD MTR_IVL "meter interval sub" *SUBSTRUCT // substruct for one meter for o
*p float bt // battery output (negative)
*e float pv // photovoltaic array output (negative)
*e float allEU // subtotal, clg .. usr2 (= load w/o bt and pv)

#endif // METER_DBL

// cost results. for now (11-93), must report with probes. Code (cnguts) may assume in this order, after uses.
*p float cost // accumulated tot*rate
*p float dmdCost // largest dmd*dmdRate to month level, then accumulates (mtr_Accum)
Expand All @@ -5492,6 +5532,10 @@ RECORD MTR "meter" *RAT // Meter input/runtime: energy use by meter, interval,
*declare "void mtr_HrInit();"
*declare "bool mtr_HasSubmeter() const { return mtr_subMtri[ 0] != 0; }"
*declare "void mtr_AccumFromSubmeters();"
*declare "RC mtr_Validate() const;"
*declare "MTR_IVL* mtr_GetMTRIVL( int ivl) { return &Y + (ivl - C_IVLCH_Y); }"
*declare "const MTR_IVL* mtr_GetMTRIVL( int ivl) const { return &Y + (ivl - C_IVLCH_Y); }"


// inputs: rates
*i float rate // cost per Btu of use
Expand Down
Loading