enzyme -> RTL: convert the HostMetrics screen suites - #441
Merged
Conversation
Migrate the HostMetrics screen's test suite off enzyme/mountWithContexts onto renderWithContexts (React Testing Library). Behaviour and assertions are preserved; interactions go through accessible roles and real user events.
blaipr
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the incremental enzyme → React Testing Library migration by converting the HostMetrics screen test suite to use renderWithContexts and RTL queries, without changing production UI code.
Changes:
- Replaced enzyme
mountWithContexts+act/waitForElementusage with RTLrenderWithContextsand@testing-library/reactutilities. - Updated assertions to validate post-load rendering via DOM/RTL queries and API call verification.
Comment on lines
+38
to
+43
| renderWithContexts( | ||
| <HostMetrics | ||
| match={{ path: '/hosts', url: '/hosts' }} | ||
| location={{ search: '', pathname: '/hosts' }} | ||
| /> | ||
| ); |
Comment on lines
+57
to
+59
| expect( | ||
| document.querySelectorAll('[id^="host_metrics-row-"]') | ||
| ).toHaveLength(1); |
Contributor
Author
|
Thanks for the review. The ignored match and location props are gone, and the host row count is asserted via an accessible role query instead of querySelectorAll. |
cigamit
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Converts the HostMetrics screen's test suite from enzyme to React Testing Library, continuing the incremental enzyme → RTL migration (one screen directory per PR).
HostMetrics.test.jsmigrated offmountWithContexts/enzyme ontorenderWithContexts: list rendering and row presence after data load. Interactions go through accessible roles and real user events. Behaviour and assertions are preserved.ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
npm testfor the HostMetrics directory: 1 suite, 2 tests, all passing. ESLint clean. No production code changed — test-only.