Skip to content

enzyme -> RTL: convert the HostMetrics screen suites #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cigamit merged 2 commits into from
Jun 18, 2026
Merged

enzyme -> RTL: convert the HostMetrics screen suites #441

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3050653
Convert HostMetrics screen tests from enzyme to React Testing Library
blaipr Jun 16, 2026
e18a630
Address Copilot review comments
blaipr Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 12 additions & 27 deletions awx/ui/src/screens/HostMetrics/HostMetrics.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
import React from 'react';
import { act } from 'react-dom/test-utils';
import { screen, waitFor } from '@testing-library/react';
import { HostMetricsAPI } from 'api';
import {
mountWithContexts,
waitForElement,
} from '../../../testUtils/enzymeHelpers';
import { renderWithContexts } from '../../../testUtils/rtlContexts';

import HostMetrics from './HostMetrics';

Expand All @@ -23,14 +20,6 @@ const mockHostMetrics = [
},
];

function waitForLoaded(wrapper) {
return waitForElement(
wrapper,
'HostList',
(el) => el.find('ContentLoading').length === 0
);
}

describe('<HostMetrics />', () => {
beforeEach(() => {
HostMetricsAPI.read.mockResolvedValue({
Expand All @@ -46,24 +35,20 @@ describe('<HostMetrics />', () => {
});

test('initially renders successfully', async () => {
await act(async () => {
mountWithContexts(
<HostMetrics
match={{ path: '/hosts', url: '/hosts' }}
location={{ search: '', pathname: '/hosts' }}
/>
);
});
renderWithContexts(<HostMetrics />);
await waitFor(() =>
expect(screen.queryByRole('progressbar')).not.toBeInTheDocument()
);
});

test('HostMetrics are retrieved from the api and the components finishes loading', async () => {
let wrapper;
await act(async () => {
wrapper = mountWithContexts(<HostMetrics />);
});
await waitForLoaded(wrapper);
renderWithContexts(<HostMetrics />);
await waitFor(() =>
expect(screen.queryByRole('progressbar')).not.toBeInTheDocument()
);

expect(HostMetricsAPI.read).toHaveBeenCalled();
expect(wrapper.find('HostMetricsListItem')).toHaveLength(1);
expect(screen.getByText('Host name')).toBeInTheDocument();
expect(screen.getAllByRole('cell', { name: 'Host name' })).toHaveLength(1);
});
});