Bump sass-loader from 16.0.8 to 17.0.0 - #542
Merged
Merged
Conversation
…ll need to work on the lightmode.
… name. If the Th is intended to be visually empty, pass in screenReaderText. If the Th contains only non-text, interactive content such as a checkbox or expand toggle, pass in an aria-label."
blaipr
force-pushed
the
bump/sass-loader-17.0.0
branch
from
June 28, 2026 15:51
1e39fc0 to
cb81f1e
Compare
- Bump react-router from 7.18.0 to 8.0.1 (requires React 19.2.7+) - Add import.meta transform to Jest babel config (react-router 8 uses import.meta.hot which Jest cannot parse without it) - Consolidate transformIgnorePatterns into single pattern including react-router alongside d3 and has-ansi All 552 test suites pass (2911 tests).
routerCompat.js was a re-export shim from the v5→v6→v7 migration — all 295 imports now use react-router directly. The history package (used by 191 test files for createMemoryHistory) is replaced by a Jest moduleNameMapper shim that delegates to react-router's UNSAFE_createMemoryHistory with v5Compat enabled. No test file changes needed — they still import from 'history' and the mapper redirects to the shim.
react-router 8 re-exports everything from a single module, so separate import lines from 'react-router' trigger ESLint's import-x/no-duplicates rule. Merge them into single imports. Also fix rtlContexts.js to import createMemoryHistory from the local historyShim instead of the removed 'history' package.
blaipr
force-pushed
the
bump/sass-loader-17.0.0
branch
from
June 28, 2026 16:13
cb81f1e to
dcd8fe9
Compare
Contributor
Author
|
Rebased to resolve merge conflicts. |
cigamit
added
the
Needs triage
blaipr
force-pushed
the
bump/sass-loader-17.0.0
branch
from
June 28, 2026 16:21
dcd8fe9 to
6c2e610
Compare
Contributor
Author
|
Rebased to resolve merge conflicts. |
cigamit
removed
the
Needs triage
cigamit
approved these changes
Jun 28, 2026
3 tasks
sy-base
pushed a commit
to sy-base/ascender
that referenced
this pull request
Jul 4, 2026
* Fix css issues after migrating to PF6. This fixes the dark theme, still need to work on the lightmode. * Fix issue with Workflow Node Edit Nav names * Fix mouseover on workflow node link * A few more fixes * Fix dashes in ace coder * Resolve PF6 warnings about "Th: Table headers must have an accessible name. If the Th is intended to be visually empty, pass in screenReaderText. If the Th contains only non-text, interactive content such as a checkbox or expand toggle, pass in an aria-label." * Upgrade react-router from 7.18.0 to 8.0.1 - Bump react-router from 7.18.0 to 8.0.1 (requires React 19.2.7+) - Add import.meta transform to Jest babel config (react-router 8 uses import.meta.hot which Jest cannot parse without it) - Consolidate transformIgnorePatterns into single pattern including react-router alongside d3 and has-ansi All 552 test suites pass (2911 tests). * Remove routerCompat.js indirection and history devDependency routerCompat.js was a re-export shim from the v5→v6→v7 migration — all 295 imports now use react-router directly. The history package (used by 191 test files for createMemoryHistory) is replaced by a Jest moduleNameMapper shim that delegates to react-router's UNSAFE_createMemoryHistory with v5Compat enabled. No test file changes needed — they still import from 'history' and the mapper redirects to the shim. * Merge duplicate react-router imports and fix history shim react-router 8 re-exports everything from a single module, so separate import lines from 'react-router' trigger ESLint's import-x/no-duplicates rule. Merge them into single imports. Also fix rtlContexts.js to import createMemoryHistory from the local historyShim instead of the removed 'history' package. * Bump terser-webpack-plugin from 5.6.0 to 5.6.1 * Bump globals from 17.4.0 to 17.7.0 * Bump webpack from 5.106.2 to 5.108.1 * Bump postcss-preset-env from 7.8.3 to 11.3.2 * Bump sass-loader from 16.0.8 to 17.0.0 --------- Co-authored-by: Jimmy Conner <jconner@ciq.com> Co-authored-by: test <test@test.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
npm testpassesnpm run buildsucceeds