Skip to content

Remove unused resolve-url-loader - #546

Merged
cigamit merged 1 commit into
ctrliq:mainfrom
blaipr:chore/remove-resolve-url-loader
Jun 28, 2026
Merged

Remove unused resolve-url-loader#546
cigamit merged 1 commit into
ctrliq:mainfrom
blaipr:chore/remove-resolve-url-loader

Conversation

@blaipr

@blaipr blaipr commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Only referenced in the sass/scss webpack rule chain
  • Zero SCSS files exist in the project, so the rule never fires
  • Simplified getStyleLoaders to pass preProcessor directly without resolve-url-loader indirection

Test plan

  • npm test passes
  • npm run build succeeds
  • Dev server starts without errors

@blaipr
blaipr force-pushed the chore/remove-resolve-url-loader branch 2 times, most recently from 205f927 to ee2ce95 Compare June 28, 2026 16:14
@blaipr

blaipr commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Rebased to resolve merge conflicts.

@cigamit cigamit self-assigned this Jun 28, 2026
@cigamit cigamit added the Needs triage When a Issue needs to be researched or a PR has an issue that needs fixing before merging label Jun 28, 2026
@blaipr
blaipr force-pushed the chore/remove-resolve-url-loader branch from ee2ce95 to f8599d3 Compare June 28, 2026 16:21
@blaipr

blaipr commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Rebased to resolve merge conflicts.

@blaipr
blaipr force-pushed the chore/remove-resolve-url-loader branch from f8599d3 to e59d415 Compare June 28, 2026 16:33
@cigamit cigamit removed the Needs triage When a Issue needs to be researched or a PR has an issue that needs fixing before merging label Jun 28, 2026
@cigamit
cigamit merged commit cfd44fb into ctrliq:main Jun 28, 2026
@blaipr

blaipr commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Rebased against current main (post-#541/#542/#545 merges). Conflicts resolved.

sy-base pushed a commit to sy-base/ascender that referenced this pull request Jul 4, 2026
@blaipr @sy-base
Remove unused resolve-url-loader (ctrliq#546)
f1528ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cigamit cigamit cigamit approved these changes

Assignees

@cigamit cigamit

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blaipr @cigamit