Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circleci: add a job using libssh #8444

Closed
wants to merge 3 commits into from
Closed

circleci: add a job using libssh #8444

wants to merge 3 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Feb 12, 2022

No description provided.

@bagder bagder added the CI label Feb 12, 2022
@bagder
Copy link
Member Author

@bagder bagder commented Feb 12, 2022

I spotted that we have no CI build using libssh

@bagder
Copy link
Member Author

@bagder bagder commented Feb 12, 2022

This makes test 1459 fail, using libssh/0.9.3/openssl/zlib.

On my local machine I have libssh/0.9.6/openssl/zlib and I cannot reproduce the failure.

... and make test 1459 check for the different return code then.
bagder added a commit that referenced this issue Feb 14, 2022
@bagder bagder deleted the bagder/circleci-libssh branch Feb 14, 2022
pghmcfc added a commit to pghmcfc/curl that referenced this issue Mar 6, 2022
The 'oldlibssh' feature indicates that the error code returned by libssh
for a broken known_hosts file should be 67 rather than 60 (test1459).
This feature was added as part of curl#8444 with 'oldlibssh' mapping to
libssh versions prior to 0.9.6, and then refined as part of curl#8511 to map
to versions prior to 0.9.5.

In Red Hat Enterprise Linux 8.5 there is a patched version of libssh
version 0.9.4 (https://git.centos.org/rpms/libssh/blob/c8/f/SOURCES)
in which test1459 fails because it returns the "new" value rather than
the "old" one. It's plausible that one of the patches is responsible
for this rather than the underlying code but I don't think so.

This change therefore drops the 'oldlibssh' version check to map to
libssh versions older than 0.9.4, which fixes builds on RHEL-8.
bagder pushed a commit that referenced this issue Mar 7, 2022
The 'oldlibssh' feature indicates that the error code returned by libssh
for a broken known_hosts file should be 67 rather than 60 (test1459).
This feature was added as part of #8444 with 'oldlibssh' mapping to
libssh versions prior to 0.9.6, and then refined as part of #8511 to map
to versions prior to 0.9.5.

In Red Hat Enterprise Linux 8.5 there is a patched version of libssh
version 0.9.4 (https://git.centos.org/rpms/libssh/blob/c8/f/SOURCES) in
which test1459 fails because it returns the "new" value rather than the
"old" one. It's plausible that one of the patches is responsible for
this rather than the underlying code but I don't think so.

This change therefore drops the 'oldlibssh' version check to map to
libssh versions older than 0.9.4, which fixes builds on RHEL-8.

Closes #8548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI SCP/SFTP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant