PR review medium effort fixes: deduplicate canonicalizers and optimiz…#144
Merged
Transurgeon merged 1 commit intocvxpy-mergefrom Feb 3, 2026
Merged
PR review medium effort fixes: deduplicate canonicalizers and optimiz…#144Transurgeon merged 1 commit intocvxpy-mergefrom
Transurgeon merged 1 commit intocvxpy-mergefrom
Conversation
…e bounds - Add _common.py with canonicalize_unary_smooth() helper to reduce code duplication across hyperbolic, trig, exp, and prod canonicalizers - Refactor canonicalizer files to use the common helper - Preallocate numpy arrays in Bounds class instead of list extend + convert - Fix hessian() to return typed empty array (dtype=np.float64) - Cache empty hessian structure in hessianstructure() for quasi-Newton Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Benchmarks that have stayed the same: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e bounds
Description
Please include a short summary of the change.
Issue link (if applicable):
Type of change
Contribution checklist