EUN Coordinate System - #2228
Merged
Merged
Conversation
DavidMansolino
commented
Sep 11, 2020
| if (WbWorld::instance()->worldInfo()->coordinateSystem() == "ENU") | ||
| return enu_swap[i]; | ||
| else | ||
| else // "NUE" or "EUN" |
Member
Author
There was a problem hiding this comment.
I am not sure in the EUN case it makes sense to rotate the background.
In the ENU case it clearly makes sense since the sky should be up, but here the sky is already up, and in the background, there is no notion of north and east but rather front and right. Furthermore, if we want to keep 100% compatibility with < R2020b worlds with northDirection set to '0 0 1' we should not rotate it.
@cyberbotics/maintainers what do you think?
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements: #2220
In addition, it brings several cleanups from #1643 and generalizes the coordinate system implementation (it will be extremely simple in the future to add more coordinate system).