[DS][26/n] Update internal representation of InLatestTimeWindow

[OwenKephart]

Summary & Motivation

Updates the internal representation to better match the timedelta class. The painful thing here is that you can't really set a constructor when using pydantic models.

Not a huge fan of representing "no timedelta at all" as "all the things are 0"

How I Tested These Changes

[OwenKephart]

• [DS][29/n] Create ParentNewerCondition #21641 : 2 dependent PRs (#21670 , #21671 )
• [DS][28/n] Create WillBeRequestedCondition #21640
• [DS][27/n] Make candidate_slice and true_slice Optional #21648
• [DS][26/n] Update internal representation of InLatestTimeWindow #21615 👈
• [DS][25/n] Narrow extra_state type #21613
• [DS][24/n] Remove all AssetSubset references from the context and result objects #21612
• [DS][23/n] Update SchedulingContext object #21573
• [DS][22/n] Convert SchedulingResult to DagsterModel #21546
• [DS][21/n] Rename AssetConditionResult to SchedulingResult #21545
• [DS][20/n] Port static constructors from AssetCondition to SchedulingCondition #21541
• [DS][19/n] Create SchedulingCondition object to replace AssetCondition #21540
• [DS][18/n] Move serialized objects into separate file #21539
• [DS][17/n] Move legacy files to separate legacy folder #21538
• [DS][16/n] Rename AssetConditionEvaluationContext to LegacyRuleEvaluationContext #21537
• [DS][15/n] Move operators to separate folder #21536
• [DS][14/n] Remove unused methods and properties #21535
• [DS][13/n] Convert SchedulingContext to DagsterModel #21521
• [DS][12/n] Rename SchedulingContext object #21520
• [DS][11/n] Create InProgressCondition #21511 : 1 other dependent PR (#21512 )
• [DS][10/n] Create UpdatedSinceCronCondition #21510
• [DS][9/n] Add lookback_timedelta to InLatestTimeWindow condition #21508
• [DS][8/n] Create InLatestTimeWindow condition #21507
• [DS][7/n] Create MaterializedSchedulingCondition #21505
• [DS][6/n] Create Any/AllDepsMatchSchedulingConditions #21504
• [DS][5/n] Use AssetSlice in AssetConditionResult #21503
• [DS][4/n] Rename asset_condition folder and add README #21502
• [DS][3/n] Update unique_id creation logic #21501
• [DS][2/n] Update signature of AutoMaterializeRule #21500
• [DS][1/n] Create SchedulingConditionEvaluationContext #21499
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @OwenKephart and the rest of your teammates on Graphite

[schrockn]

Might be worth nothing as comment that

>>> timedelta().days
0
>>> timedelta().seconds
0
>>> timedelta().microseconds
0

I went to the REPL and checked this to ensure it wasn't None.

[schrockn]

And actually I think you should make these optional to distinguish from the zero case.

[schrockn]

Let's make the serialized representation nullable to distinguihs from the default/empty timedelta.

I also recommend making it a tuple so there is only one Noneable property.

[schrockn]

Change serialization format

[OwenKephart]

Merge activity

• May 14, 10:38 AM EDT: @OwenKephart started a stack merge that includes this pull request via Graphite.
• May 14, 10:40 AM EDT: Graphite rebased this pull request as part of a merge.
• May 14, 10:43 AM EDT: @OwenKephart merged this pull request with Graphite.