[DS][25/n] Narrow extra_state type #21613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 2, 2024
schrockn
reviewed
May 2, 2024
| @@ -31,6 +30,10 @@ | |||
|
|
|||
| T = TypeVar("T") | |||
|
|
|||
| # state objects that store arbitrary data between ticks | |||
| # if a need for new types arises, they can be added here, as long as they are serializable | |||
| SerializableState = Union[None, AssetSubset, Sequence[ValidAssetSubset]] | |||
There was a problem hiding this comment.
I don't think we should assign a name to this union. It's too general of name given what it is.
Can we just canonicalize to 'Optional[Sequence[ValidAssetSubset]]`?
schrockn
requested changes
May 2, 2024
|
Fine with not giving it a name, but I don't want to mess with disallowing a singular AssetSubset at the moment (as we have plenty of already-stored information that is just a single AssetSubset) |
|
Makes complete sense to not change then given that we are dealing with already persisted data 👍🏻 |
OwenKephart
force-pushed
the
05-02-Remove_all_AssetSubset_references_from_the_context_and_result_objects
branch
from
6baf92a
to
e5e6ed8
Compare
OwenKephart
force-pushed
the
05-02-Narrow_extra_state_type
branch
from
2baaba6
to
bf37d9b
Compare
OwenKephart
force-pushed
the
05-02-Remove_all_AssetSubset_references_from_the_context_and_result_objects
branch
from
e5e6ed8
to
41e4314
Compare
OwenKephart
force-pushed
the
05-02-Narrow_extra_state_type
branch
from
bf37d9b
to
c3c890f
Compare
schrockn
approved these changes
May 3, 2024
This was referenced May 3, 2024
OwenKephart
force-pushed
the
05-02-Remove_all_AssetSubset_references_from_the_context_and_result_objects
branch
from
41e4314
to
a03b80f
Compare
OwenKephart
force-pushed
the
05-02-Narrow_extra_state_type
branch
from
c3c890f
to
3ccd4be
Compare
Merge activity
|
OwenKephart
force-pushed
the
05-02-Remove_all_AssetSubset_references_from_the_context_and_result_objects
branch
from
a03b80f
to
2fb533a
Compare
Base automatically changed from
05-02-Remove_all_AssetSubset_references_from_the_context_and_result_objects
to
master
May 3, 2024 22:28
OwenKephart
force-pushed
the
05-02-Narrow_extra_state_type
branch
from
3ccd4be
to
7b5f20e
Compare
cmpadden
pushed a commit
that referenced
this pull request
May 6, 2024
## Summary & Motivation As title -- we only need a subset of the full PackableValue type, and can always widen this later ## How I Tested These Changes
This was referenced May 6, 2024
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
## Summary & Motivation As title -- we only need a subset of the full PackableValue type, and can always widen this later ## How I Tested These Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
As title -- we only need a subset of the full PackableValue type, and can always widen this later
How I Tested These Changes