Try to handle Canon RF lenses differently to legacy ones#11584
Merged
Conversation
Contributor
Author
|
Actually, scratch that, will only work w/ exiv2 main branch, so a no-go ATM. Will work on the alternative approach then... |
kmilos
marked this pull request as draft
April 21, 2022 12:36
kmilos
changed the title
kmilos
marked this pull request as ready for review
April 21, 2022 15:15
TurboGit
added
the
scope: camera support
Contributor
|
Wonderful, fixed my issue with the 100-500 getting wrongly identified as with +2x extender |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses RF lens aliasing such as #11581
Requires exiv2 0.27.5, but not all RF lenses are included w/ exiv2 unfortunately (21 out of 31 known to exiftool).The alternative is to detect the RF case, prioritize Exif.Canon.LensModel, and then try to string replace "RF" w/ "Canon RF "...