Additional button to remove the star rating of an image

[deekayhd]

This is a proposal for issue #21127 .
Currently, the only way to remove the star rating of an image is either by using the shortcut 0 or by clicking the first star in a toggle fashion. When more than one star has been set for an image, you have to click the first star twice. This is not very intuitive.
With this PR two new dedicated buttons are introduced to remove the star rating of an image in the same fashion as setting the rating.
At the bottom of the window

and on the thumbnail overlay

closes #21127

[TurboGit]

But then should we keep the double-click on 1 star to remove the rating?

Note that this was done to avoid too much encumbered thumbs especially when using small ones.

[deekayhd]

But then should we keep the double-click on 1 star to remove the rating?

I would keep the double-click, because some may be used to it and get confused.

Note that this was done to avoid too much encumbered thumbs especially when using small ones.

I do not think that this is a problem. When the thumb gets too small, the stars are not visible, anyway.
If you have serious doubts, we could just add the new button at the bottom of the lighttable and leave the thumbnails as they are (primarily as a display of the rating).

[deekayhd]

@TurboGit Do you consider this PR for 6.8? If I understand correctly, it needs some adjustments due to the changes in PR #21659. Of course, I will do the adjustments, if necessary.

[Arecsu]

@deekayhd hey hello! Just a heads up, many things are changing with all this gtk4-prep. If needed to adapt your code to it, don't highly trust the assessment at #21659 that quotes this PR. It serves as a guidance, but be sure to check how other similar interactions are being done at master and possibly some gtk4-prep open PRs.

My last #21745 PR (still not in master at the moment of writing this) simplified a couple of things, so it should become easier to understand as we go. Luckily the code you might need to change seems to be a couple of lines at worst, so there shouldn't be huge surprises!

There is also this guide which can become handy: https://docs.gtk.org/gtk4/migrating-3to4.html

If using an LLM / AI coding tool, here is some helpful tips that I use in my workflow:

• make it use https://docs.gtk.org/gtk4/migrating-3to4.html by fetching it and read it
• make it use gh-cli. If you don't have it in your system (github CLI), do it, incredibly handy!
• with gh-cli it should automate the search and exploration of issues and PRs
• make it read and understand any possible gtk4-prep open PRs at darktable-org/darktable repo, even your own PRs if needed
• use your own (or helped with) senses to know if it would be a good idea to merge those PRs locally prior to do your own work
• and also say to it that any commit titled gtk4-prep in the git history of the master branch should be helpful, along with other patterns in the current code, to know how to adapt your code to work with this preparation

I believe these guidelines are universal and would help plenty of other developers as well when it comes to merging new PRs in this phase. Of course, if you don't use any LLMs, well, you can always inspect the code yourself. It's the same process, but possibly a bit slower, although some people are pretty good at this!

CC to @TurboGit because this message could be useful for other people as well