modulegroups: dynamically select tone-mapper defaults in beginner preset (fixes #20959) - #21255
modulegroups: dynamically select tone-mapper defaults in beginner preset (fixes #20959)#21255Mr-Charvaka wants to merge 1 commit into
Conversation
|
If this PR was generated with AI assistance, please note that. What kind of testing was done? Was it only tested to make sure the problem was fixed or was testing also done to make sure there were no regressions or issues created by the fix? |
|
@wpferguson I have updated the PR you can find the specific testing approach, regression safety checks, and implementation breakdown posted directly in the Pull Request description at the top of this page. |
|
The goal here was to always use sigmoid for beginner workflow as this is the simplest tone mapper. |
|
This pull request has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please verify it has no conflicts with the master branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work. |
Resolves #20959.
Purpose & Goal
Ensure the beginner preset in Quick Access Panel (QAP) respects active user workflow preferences (
filmicrgb,agx, orsigmoid) rather than always hardcodingsigmoid.Implementation Details
src/libs/modulegroups.cto inspect the workflow configuration (plugins/darkroom/workflow).filmicrgb,agx, orsigmoidbased on active workflow settings.Testing & Verification Approach
Regression Safety
Maintains safe fallback behavior and respects existing scene-referred configuration schemes without breaking legacy presets.
Development Note
This pull request was prepared with AI-assisted pair-programming (using the Gemini-powered Antigravity agent), and has been manually reviewed and refined for correctness.