Fix raw denoise crash on raws with tight CFA border#21500
Merged
Conversation
andriiryzhkov
added
bugfix
1 task
Member
|
Needs a release note entry, TIA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21497
dt_restore_raw_bayer's per-tile "extended extent" addssensor_Opixels on any side with a neighbour tile, but doesn't clamp to the CFA buffer bounds. On raws where the visible area sits tight against the sensor edge (e.g.visible 3632x2720 in a 3648x2736 sensor) the extension overshoots the buffer andcfa_in[sr * width + sc]reads past the allocation – classicMALLOC_LARGEgap crash.Fix: clamp the four extents in
restore_raw_bayer.cto[0, width) × [0, height). Interior tiles unchanged; boundary tiles get clipped to what actually exists.