Fall back to finite-diff tangent when analytic derivative is zero#21561
Merged
Conversation
Collaborator
Author
|
For release notes: In Bug Fixes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21525 and #21557
Path masks with
ctrl == cornerat a segment endpoint (potrace routinely emits this) hit the exact-zero branch in_path_border_get_XY, which returnedDT_INVALID_COORDINATE. Gap-fill then bailed on invalid input and the border polyline connected surviving points across huge distances - the chaotic wide crossing lines reported.Fall back to a finite-difference sample of the curve for those cases. Non-degenerate paths hit the analytic branch as before, so existing masks and the integration tests are byte-identical.
Replaces the earlier attempt in be7259b (which switched to finite-diff unconditionally and shifted every path mask by a few pixels)