Fix theme changes only taking effect on the next load - #21620
Open
cyberhirsch wants to merge 1 commit into
Open
Conversation
dt_gui_load_theme() created a new GtkCssProvider on every call and added it to the screen. gtk_style_context_add_provider_for_screen() takes its own reference, so the g_object_unref() at the end never removed it and providers accumulated, all at GTK_STYLE_PROVIDER_PRIORITY_USER + 1. With several providers at the same priority the oldest one still won the @define-color lookups, so selecting a theme appeared to do nothing until the theme was loaded again -- switching to another theme and back was the usual workaround. Create the provider once and replace its data on subsequent calls. While here, the theme selector in preferences silently fell back to list index 0 when the configured theme didn't match any entry, so an unknown or empty value was displayed as whichever theme happened to sort first rather than as the actual default. Fall back to the configured default instead, and free the per-entry name string, which the combobox copies.
Member
Can you clarify? And a way to reproduce because I don't see that on my side. TIA. |
Member
|
@cyberhirsch : Just a gentle ping for my previous question. TIA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dt_gui_load_theme() created a new GtkCssProvider on every call and added it to the screen. gtk_style_context_add_provider_for_screen() takes its own reference, so the g_object_unref() at the end never removed it and providers accumulated, all at GTK_STYLE_PROVIDER_PRIORITY_USER + 1. With several providers at the same priority the oldest one still won the @define-color lookups, so selecting a theme appeared to do nothing until the theme was loaded again -- switching to another theme and back was the usual workaround.
Create the provider once and replace its data on subsequent calls.
While here, the theme selector in preferences silently fell back to list index 0 when the configured theme didn't match any entry, so an unknown or empty value was displayed as whichever theme happened to sort first rather than as the actual default. Fall back to the configured default instead, and free the per-entry name string, which the combobox copies.