tests: stop using cmocka's deprecated check_expected() - #21752
Merged
Conversation
piratenpanda
changed the title
Contributor
|
I think there is a similar issue when building with Edit: nevermind, this is a different issue. I'll look into that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While building unit tests for the spektrafilm module I hit a compilation error. cmocka 1.1.8 deprecated the untyped check_expected() in favour of the width-explicit check_expected_int() / check_expected_uint(). The unit tests are built with -Werror, so on any distribution shipping that version test_filmicrgb no longer compiles, and with it every -DBUILD_TESTING=ON build fails.
Use the typed macro where it exists and keep the old spelling behind an #ifdef: the minimum cmocka the build accepts is 1.1.0, which has no typed variants, so dropping the old spelling outright would break the other end of the supported range.