2020/05/14 sync tweaks by lukaszkolodziejczyk · Pull Request #1898 · angulardart/angular

lukaszkolodziejczyk · 2020-07-15T15:09:54Z

No description provided.

PiperOrigin-RevId: 311549333

googlebot · 2020-07-15T15:10:21Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

googlebot · 2020-07-15T20:47:03Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Using code_builder version 3.3.0+ breaks the test "should handle relative paths in a test directory" (reflector_test.dart). Every code_builder version 3.0.1+ emits two imports during this test, but starting from version 3.3.0, the imports are emitted in a different order.

Since AngularDart 6.0.0, map and list literals are no longer supported inside templates and cause compilation errors.

During instantiation of NgTestBed, generic type is not specialized: var testBed = NgTestBed.forComponent(...); The way methods of NgTestBed are currently invoked violate analyzer's 'argument_type_not_assignable' rule (see below for reference). await fixture.update((AccessorTestComponent c) { ... }); The appropriate with respect to analuzer rules invocation is the following: await fixture.update((c) { ... });

As the result of this commit, more tests for PKG="_tests" are passing. PiperOrigin-RevId: 312745372

safe_html package is unavailable so the following does not compile: SafeHtml get content => SafeHtml.sanitize(comment['content']); Apply alternative approach using angular.security: SafeHtml get content => _sanitizer.bypassSecurityTrustHtml(comment['content']);

PiperOrigin-RevId: 312350039

Used `dart tool/update.dart`

Url sanitizer takes an unsafe_url and turns it into 'unsafe:$unsafe_url'. See implementation: angular/lib/src/security/url_sanitizer.dart#L35

Sanitization implementation completely removes iframe's srcdoc if it contains unsafe HTML.

API changes introduced to analyzer 0.39.15 broke angular_analyzer_plugin build.

kevmoo

until we're ready to publish, we should keep -dev postfixes on versions

* Bump version to 0.6.0-dev * Add CHANGELOG.md

* Bump version to 0.5.0-dev * Add CHANGELOG.md * Add missing deps to pubspec.yaml - angular_ast: ^0.6.0 - csslib: ^0.16.1

* Bump version to 6.0.0 * Add CHANGELOG.md * Bump angular_ast and angular_compiler versions in pubspec.yaml - angular_ast: 0.6.0 - angular_compiler: 0.5.0

* Bump version to 1.0.0-dev * Add CHANGELOG.md * Modify pubspec.yaml - angular_ast: ^0.6.0 - add 'matcher: ^0.12.9' to dev deps

* Bump version to 1.0.0-dev * Modify pubspec.yaml - angular_analyzer_plugin: '1.0.0'

* Bump version to 3.0.0-dev * Add CHANGELOG.md * Modify pubspec.yaml - angular: ^6.0.0

* Bump version to 3.0.0-dev * Add CHANGELOG.md * Modify pubspec.yaml - angular: ^6.0.0 - angular_test: ^3.0.0

* Bump version to 2.0.0-dev * Add CHANGELOG.md * Modify pubspec.yaml - angular: ^6.0.0 - angular_test: ^3.0.0

Project import generated by Copybara.

49b2d78

PiperOrigin-RevId: 311549333

googlebot added the cla: no label Jul 15, 2020

lukaszkolodziejczyk marked this pull request as ready for review July 15, 2020 18:36

lukaszkolodziejczyk force-pushed the 2020_05_14_sync_tweaks branch from e9ee6d9 to 818e67c Compare July 15, 2020 18:37

lukaszkolodziejczyk changed the base branch from 82A631C974191BF08D860B6FD6B36F61 to master July 15, 2020 18:41

lukaszkolodziejczyk force-pushed the 2020_05_14_sync_tweaks branch from 818e67c to eec0b8b Compare July 15, 2020 20:46

lukaszkolodziejczyk force-pushed the 2020_05_14_sync_tweaks branch 7 times, most recently from 6dd6480 to 0ef6faa Compare July 21, 2020 18:04

kevmoo and others added 15 commits July 22, 2020 10:32

local tweaks

5fa3654

temp: running everything – see what breaks

0307822

angular_compiler: replace package_resolver with package_config

98ad2a2

angular_router: add missing ng.initReflector() invocation

1ea79f5

angular_test: add missing ng.initReflector() invocation

1fa685f

_tests: remove / edit tests with literal lists syntax in templates

8abb8b4

Since AngularDart 6.0.0, map and list literals are no longer supported inside templates and cause compilation errors.

_tests: replace package_resolver with package_config

7e1acae

_tests: add missing ng.initReflector() invocation

7613851

angular_compiler: ensure valid session from a new LibraryElement

3b6908e

As the result of this commit, more tests for PKG="_tests" are passing. PiperOrigin-RevId: 312745372

examples/i18n: remove empty analysis_options.yaml

777f8ca

_goldens: fix generate_for path in build.yaml

d953bc4

Lukasz Kolodziejczyk added 5 commits July 22, 2020 10:32

_goldens: remove list literals

5e960fc

PiperOrigin-RevId: 312350039

_goldens: update goldens

28a7c6a

Used `dart tool/update.dart`

_tests: change unsafe url test expectations

00fc56a

Url sanitizer takes an unsafe_url and turns it into 'unsafe:$unsafe_url'. See implementation: angular/lib/src/security/url_sanitizer.dart#L35

_tests: adjust iframe's srcdoc sanitization test

ba772fd

Sanitization implementation completely removes iframe's srcdoc if it contains unsafe HTML.

appveyor: take hacker_news_pwa as an example

a6c1e86

lukaszkolodziejczyk force-pushed the 2020_05_14_sync_tweaks branch 6 times, most recently from 57c9668 to 6ae1889 Compare July 27, 2020 12:19

angular_analyzer_plugin: set ceiling for analyzer dependency

e07526c

API changes introduced to analyzer 0.39.15 broke angular_analyzer_plugin build.

lukaszkolodziejczyk force-pushed the 2020_05_14_sync_tweaks branch from bf5582b to e69cadf Compare July 28, 2020 17:59

kevmoo approved these changes Jul 28, 2020

View reviewed changes

Lukasz Kolodziejczyk added 8 commits July 29, 2020 10:22

angular_ast: prepare for publishing

73d1cce

* Bump version to 0.6.0-dev * Add CHANGELOG.md

angular_compiler: prepare for publishing

1ae0253

* Bump version to 0.5.0-dev * Add CHANGELOG.md * Add missing deps to pubspec.yaml - angular_ast: ^0.6.0 - csslib: ^0.16.1

angular: prepare for publishing

9bbef14

* Bump version to 6.0.0 * Add CHANGELOG.md * Bump angular_ast and angular_compiler versions in pubspec.yaml - angular_ast: 0.6.0 - angular_compiler: 0.5.0

angular_analyzer_plugin: prepare for publishing

4837cab

* Bump version to 1.0.0-dev * Add CHANGELOG.md * Modify pubspec.yaml - angular_ast: ^0.6.0 - add 'matcher: ^0.12.9' to dev deps

analyzed_angular_plugin_loader: bump version

75c03d9

* Bump version to 1.0.0-dev * Modify pubspec.yaml - angular_analyzer_plugin: '1.0.0'

angular_test: prepare for publishing

48e62f5

* Bump version to 3.0.0-dev * Add CHANGELOG.md * Modify pubspec.yaml - angular: ^6.0.0

angular_forms: prepare for publishing

5726e9a

* Bump version to 3.0.0-dev * Add CHANGELOG.md * Modify pubspec.yaml - angular: ^6.0.0 - angular_test: ^3.0.0

angular_router: prepare for publishing

370deb5

* Bump version to 2.0.0-dev * Add CHANGELOG.md * Modify pubspec.yaml - angular: ^6.0.0 - angular_test: ^3.0.0

lukaszkolodziejczyk force-pushed the 2020_05_14_sync_tweaks branch from e69cadf to 370deb5 Compare July 29, 2020 10:44

kevmoo merged commit 6b1137b into angulardart:master Jul 30, 2020

oonid mentioned this pull request Aug 3, 2020

Don't abandon AngularDart, don't give up on AngularDart #1866

Closed

4 tasks

chalin mentioned this pull request Oct 6, 2020

Engineering notes: redirect to Angular repo angulardart/site-angulardart#79

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

2020/05/14 sync tweaks#1898

2020/05/14 sync tweaks#1898
kevmoo merged 30 commits into
angulardart:masterfrom
lukaszkolodziejczyk:2020_05_14_sync_tweaks

lukaszkolodziejczyk commented Jul 15, 2020

Uh oh!

googlebot commented Jul 15, 2020

Uh oh!

googlebot commented Jul 15, 2020

Uh oh!

kevmoo left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

lukaszkolodziejczyk commented Jul 15, 2020

Uh oh!

googlebot commented Jul 15, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

googlebot commented Jul 15, 2020

Uh oh!

kevmoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants