#3180. Add @staticInterop tests. Part 2.
#3257
Conversation
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Looks good. I added a few questions about the semantics of @staticInterop, but this mostly amounts to a suggestion that the documentation should be extended a bit, or perhaps it is not a priority because staticInterop isn't used any more.
@srujzs, do you have further comments?
@chloestefantsova, I hope you could find a little time to handle the remaining process with this PR and landing it (I'm on vacation next week)?
srujzs
left a comment
srujzs
left a comment
There was a problem hiding this comment.
I've uploaded https://dart-review.googlesource.com/c/sdk/+/441242 to address some documentation requests. Let me know if anything is confusing or undocumented that's worth adding here.
|
Updated. Mixin class annotated with |
|
@chloestefantsova I believe this PR can be merged. |
|
Looks like I have permission so I'll go ahead and do it. |
|
Thank you! |
2025-07-24 sgrekhov22@gmail.com dart-lang/co19#3180. Add `instanceof` and `instanceOfString` tests (dart-lang/co19#3260) 2025-07-22 sgrekhov22@gmail.com dart-lang/co19#3180. Add more tests for `@anonymous` annotation (dart-lang/co19#3259) 2025-07-22 sgrekhov22@gmail.com dart-lang/co19#3180. Add `@staticInterop` tests. Part 2. (dart-lang/co19#3257) 2025-07-22 sgrekhov22@gmail.com dart-lang/co19#3180. Add tests for `dartify()`. (dart-lang/co19#3258) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try Change-Id: Ia8539002298999a01ce8999aeee4368201219ed5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/442180 Reviewed-by: Erik Ernst <eernst@google.com> Reviewed-by: Alexander Thomas <athom@google.com>
3 participants
No description provided.