Skip to content

Conversation

@jslee02
Copy link
Member

@jslee02 jslee02 commented Nov 5, 2025

Summary

  • synchronize FreeJoint spatial velocity/acceleration setters with the generic joint state so VELOCITY/ACCELERATION actuators stay aligned (closes Add Kinematic Joint #1953)
  • document the behavior in FreeJoint.hpp and add a regression test that drives a VELOCITY-actuated FreeJoint purely via setSpatialVelocity
  • show that the existing FreeJoint covers the Gazebo workflow the original PR proposed without introducing a new joint type

Testing

  • pixi run lint
  • pixi run test -- tests/integration/dynamics/test_Joints.cpp
  • pixi run -e gazebo test-gz

@jslee02 jslee02 mentioned this pull request Nov 5, 2025
7 tasks
@jslee02 jslee02 marked this pull request as ready for review November 5, 2025 13:58
@jslee02 jslee02 enabled auto-merge (squash) November 5, 2025 13:58
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.48%. Comparing base (dd6f423) to head (d4c14a3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2112   +/-   ##
=======================================
  Coverage   61.48%   61.48%           
=======================================
  Files         393      393           
  Lines       33155    33157    +2     
  Branches     4084     4085    +1     
=======================================
+ Hits        20384    20386    +2     
+ Misses      12771    12770    -1     
- Partials        0        1    +1     
Flag Coverage Δ
unittests 61.48% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
dart/dynamics/FreeJoint.cpp 75.91% <100.00%> (+0.17%) ⬆️
dart/dynamics/FreeJoint.hpp 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jslee02 jslee02 merged commit 24c971c into main Nov 5, 2025
32 checks passed
@jslee02 jslee02 deleted the resolve_pr1953 branch November 5, 2025 15:55
@jslee02 jslee02 added this to the DART 7.0 milestone Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants