-
Notifications
You must be signed in to change notification settings - Fork 291
Parse SDF mimic joints and retarget mimic pendulum example #2254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of local followers - Updated configureMimicMotors in both example and test to get reference joints from middle pendulum (pendulum_with_base) instead of same skeleton - Modified MimicPairView to track middleReference from the middle pendulum - Updated GUI renderMimicTable to show error against middle pendulum reference - Made GUI widget resizable with initial size 800x600 - Added ImGuiTableFlags_Resizable for resizable table columns - Per-step mimic tracking ensured via MimicMotorConstraint's ERP/CFM parameters This fixes gazebosim/gz-physics#432 issue where followers now properly track the correct reference joints over extended simulations.
# Conflicts: # dart/constraint/CouplerConstraint.hpp # dart/constraint/MimicMotorConstraint.hpp
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2254 +/- ##
==========================================
+ Coverage 61.06% 61.13% +0.06%
==========================================
Files 353 353
Lines 32144 32208 +64
Branches 4182 4192 +10
==========================================
+ Hits 19628 19689 +61
- Misses 12516 12519 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<mimic>from SDF indart::utils::SdfParserand apply mimic properties to joints, choosing mimic motor vs coupler constraint from SDF metadata.This aims to address gz-physics issue #432 by reproducing the mimic pendulum scenario via SDF parsing alone.
Before creating a pull request
pixi run test-allto lint, build, and test your changes (not rerun after the latest merge; previously passed on this branch)