feat: support descriptor wallets for RPC governance votemany, votealias - #6094
Merged
PastaPastaPasta merged 2 commits intoJul 16, 2024
Merged
Conversation
knst
force-pushed
the
bp-descriptors-8-governance
branch
from
July 5, 2024 08:37
101da69 to
c72ec70
Compare
Member
|
Any reason this should be in v21 instead of 21.1? |
UdjinM6
approved these changes
Jul 6, 2024
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
RPCs
governance votemanyandgovernance votealiasuse forcely LegacyScriptPubKeyMan instead using CWallet's interface.It causes a failures such as
See https://github.com/dashpay/dash-issues/issues/59 to track progress
What was done?
Use CWallet's interfaces instead LegacyScriptPubKeyMan
How Has This Been Tested?
Functional tests
feature_governance.pyandfeature_governance_cl.pyto run by both ways - legacy and descriptor wallets.Run unit and functional tests.
Extra test done locally:
to flip flag descriptor wallets/legacy wallets for all functional tests.
Breaking Changes
N/A
Checklist: