backport: bitcoin#25222, #25648, #25651, #25772, #25905, #25951, #25971, #26103, #26250 (kernel 3)

[knst]

Issue being fixed or feature implemented

Kernel / assumeutxo related backports

What was done?

See commits.

How Has This Been Tested?

Run unit & functional tets

Breaking Changes

N/A

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[coderabbitai]

Walkthrough

The change centralizes mempool limits and relay-policy settings in CTxMemPool and MemPoolOptions. It moves argument parsing into the node layer with error reporting. Standardness APIs now receive explicit policy values. Index names are stored by BaseIndex. CoinStatsIndex uses references. Callers, RPC paths, tests, and fuzz utilities use the updated interfaces.

Estimated code review effort: 4 (Complex) | ~60 minutes

Sequence Diagram(s)

sequenceDiagram
  participant ArgsManager
  participant NodeInit
  participant MemPool
  participant Validation
  ArgsManager->>NodeInit: provide mempool arguments
  NodeInit->>MemPool: apply limits and policy settings
  MemPool->>Validation: expose configured policy and limits
  Validation->>MemPool: accept transactions using instance state

Loading

Possibly related PRs

• dashpay/dash#7237: Both changes update mempool fee-policy handling and minimum relay-fee enforcement.
• dashpay/dash#7437: Both changes modify mempool validation and standardness handling.

Suggested reviewers: udjinm6

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 8.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title identifies the backported kernel changes and lists the source Bitcoin Core pull requests.
Description check	✅ Passed	The description states that the pull request backports kernel and assumeutxo-related changes and mentions testing.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/rpc/net.cpp`:
- Around line 720-724: Update the getnetworkinfo result schema to mark the
relayfee and incrementalfee entries optional, matching the conditional emission
in the node.mempool block. Keep the existing field values and conditional
serialization unchanged.

In `@src/test/fuzz/tx_pool.cpp`:
- Around line 120-128: The fuzzed mempool constraint updates currently modify
only ArgsManager after MakeMempool constructs tx_pool, so the live pool never
receives them. Remove the later SetMempoolConstraints calls in the affected fuzz
branches, or add a test-only mechanism that reapplies the updated options
directly to tx_pool while preserving the existing fuzzed limits and expiry
behavior.

In `@src/util/thread.h`:
- Around line 9-15: Update the header containing the TraceThread declaration to
include the standard <string_view> header directly, alongside the existing
includes, so its std::string_view parameter is self-contained and does not
depend on transitive includes.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 29690af4-b7d1-4e38-b565-c32ed7b15233

📥 Commits

Reviewing files that changed from the base of the PR and between c751ae4 and 05da38d.

📒 Files selected for processing (72)

• ci/dash/lint-tidy.sh
• src/Makefile.am
• src/Makefile.test_fuzz.include
• src/index/addressindex.cpp
• src/index/addressindex.h
• src/index/base.cpp
• src/index/base.h
• src/index/blockfilterindex.cpp
• src/index/blockfilterindex.h
• src/index/coinstatsindex.cpp
• src/index/coinstatsindex.h
• src/index/spentindex.cpp
• src/index/spentindex.h
• src/index/timestampindex.cpp
• src/index/timestampindex.h
• src/index/txindex.cpp
• src/index/txindex.h
• src/init.cpp
• src/kernel/mempool_limits.h
• src/kernel/mempool_options.h
• src/mempool_args.cpp
• src/node/chainstate.cpp
• src/node/interfaces.cpp
• src/node/mempool_args.cpp
• src/node/mempool_args.h
• src/node/miner.cpp
• src/node/psbt.cpp
• src/policy/policy.cpp
• src/policy/policy.h
• src/policy/settings.cpp
• src/policy/settings.h
• src/qt/guiutil.cpp
• src/rpc/blockchain.cpp
• src/rpc/fees.cpp
• src/rpc/mempool.cpp
• src/rpc/net.cpp
• src/script/standard.cpp
• src/script/standard.h
• src/test/coinstatsindex_tests.cpp
• src/test/evo_assetlocks_tests.cpp
• src/test/evo_deterministicmns_tests.cpp
• src/test/fuzz/integer.cpp
• src/test/fuzz/key.cpp
• src/test/fuzz/partially_downloaded_block.cpp
• src/test/fuzz/policy_estimator.cpp
• src/test/fuzz/script.cpp
• src/test/fuzz/transaction.cpp
• src/test/fuzz/tx_pool.cpp
• src/test/fuzz/util.cpp
• src/test/fuzz/util.h
• src/test/fuzz/util/mempool.cpp
• src/test/fuzz/util/mempool.h
• src/test/fuzz/validation_load_mempool.cpp
• src/test/mempool_tests.cpp
• src/test/multisig_tests.cpp
• src/test/script_p2sh_tests.cpp
• src/test/transaction_tests.cpp
• src/test/txpackage_tests.cpp
• src/test/util/setup_common.cpp
• src/test/util/txmempool.cpp
• src/txmempool.cpp
• src/txmempool.h
• src/util/system.cpp
• src/util/system.h
• src/util/thread.cpp
• src/util/thread.h
• src/validation.cpp
• src/validation.h
• src/wallet/fees.cpp
• src/wallet/interfaces.cpp
• src/wallet/test/coinjoin_tests.cpp
• src/wallet/test/wallet_tests.cpp

💤 Files with no reviewable changes (12)

• src/script/standard.cpp
• src/wallet/test/coinjoin_tests.cpp
• src/policy/settings.h
• src/test/fuzz/util.cpp
• src/index/blockfilterindex.h
• src/index/addressindex.h
• src/wallet/test/wallet_tests.cpp
• src/index/spentindex.h
• src/index/timestampindex.h
• src/index/txindex.h
• src/mempool_args.cpp
• src/test/fuzz/util.h

[coderabbitai]

🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win

Mark the conditional RPC fields as optional.

When node.mempool is null, this code omits relayfee and incrementalfee. The getnetworkinfo result schema still declares both fields as required. Mark both result entries as optional.

Proposed fix

- {RPCResult::Type::NUM, "relayfee", "minimum relay fee for transactions in " + CURRENCY_UNIT + "/kB"},
- {RPCResult::Type::NUM, "incrementalfee", "minimum fee increment for mempool limiting in " + CURRENCY_UNIT + "/kB"},
+ {RPCResult::Type::NUM, "relayfee", /*optional=*/true, "minimum relay fee for transactions in " + CURRENCY_UNIT + "/kB"},
+ {RPCResult::Type::NUM, "incrementalfee", /*optional=*/true, "minimum fee increment for mempool limiting in " + CURRENCY_UNIT + "/kB"},

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/rpc/net.cpp` around lines 720 - 724, Update the getnetworkinfo result
schema to mark the relayfee and incrementalfee entries optional, matching the
conditional emission in the node.mempool block. Keep the existing field values
and conditional serialization unchanged.

[coderabbitai]

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

if ! rg -n '^\s*`#include`\s*<string_view>' src/util/thread.h; then
    echo "src/util/thread.h is missing a direct <string_view> include"
    exit 1
fi

Repository: dashpay/dash

Length of output: 210

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "File slice:"
sed -n '1,40p' src/util/thread.h | cat -n

echo
echo "Header include status:"
if grep -qE '^\s*`#include`\s*<string_view>' src/util/thread.h; then
  echo "src/util/thread.h directly includes <string_view>"
else
  echo "src/util/thread.h does not directly include <string_view>"
fi

echo
echo "All includes in src/util/thread.h:"
grep -nE '^\s*`#include`\s*<' src/util/thread.h || true

echo
echo "TraceThread declarations/usages:"
rg -n "TraceThread|std::string_view|thread_name" src/util/thread.h src -g '*.h' -g '*.cpp' | head -80

Repository: dashpay/dash

Length of output: 10846

---

Include <string_view> directly.

src/util/thread.h declares std::string_view but does not include <string_view>. Add the standard header so callers do not rely on transitive includes.

Proposed fix

 `#include` <string>
+#include <string_view>

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	#include <string>
	namespace util {
	/**
	* A wrapper for do-something-once thread functions.
	*/
	void TraceThread(const char* thread_name, std::function<void()> thread_func);
	void TraceThread(std::string_view thread_name, std::function<void()> thread_func);
	`#include` <string>
	`#include` <string_view>
	namespace util {
	/**
	* A wrapper for do-something-once thread functions.
	*/
	void TraceThread(std::string_view thread_name, std::function<void()> thread_func);

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/util/thread.h` around lines 9 - 15, Update the header containing the
TraceThread declaration to include the standard <string_view> header directly,
alongside the existing includes, so its std::string_view parameter is
self-contained and does not depend on transitive includes.

[thepastaclaw]

🔍 Review in progress — actively reviewing now (commit 4bab3fe)
Stage: Codex precheck starting
ETA: complete ~12:25 UTC (median 18m across 30 recent reviews)
Running 14m · Last checked: 2026-08-03 12:20 UTC

[github-actions]

Potential PR merge conflicts

This is advisory only. It does not block CI, but it marks PRs that will likely need a rebase depending on merge order.

If this PR merges first

These open PRs will likely need a rebase:

• #7294: feat: asset lock tx v2 with basic RPC support + tests Changed files: src/node/interfaces.cpp, src/test/evo_assetlocks_tests.cpp.
• #7437: feat!: implement Decentralized Masternode Shares DIP Changed files: src/Makefile.am, src/node/interfaces.cpp, src/policy/policy.cpp, src/txmempool.cpp, src/validation.cpp.

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/node/mempool_args.cpp`:
- Around line 32-36: Validate parsed values for -limitancestorsize,
-limitdescendantcount, -limitdescendantsize, and -maxmempool before scaling or
assigning them to mempool_limits. Reject negative or boundary-saturated results
before multiplying size values by 1'000, and ensure a saturated negative
-maxmempool value is not accepted as a valid mempool size.

In `@test/functional/combine_logs.py`:
- Around line 83-88: Update the log-path discovery logic around the existing
node0 glob to detect both layouts: direct mainnet logs at node{i}/debug.log and
nested logs at node{i}/<chain>/debug.log. Preserve the single-match validation,
select the corresponding path pattern so mainnet logs are included instead of
falling back to regtest, and add regression coverage for both layouts.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 93b899c1-b306-447e-892c-ecbe48f73e01

📥 Commits

Reviewing files that changed from the base of the PR and between 05da38d and 4bab3fe.

📒 Files selected for processing (72)

• ci/dash/lint-tidy.sh
• src/Makefile.am
• src/Makefile.test_fuzz.include
• src/index/addressindex.cpp
• src/index/addressindex.h
• src/index/base.cpp
• src/index/base.h
• src/index/blockfilterindex.cpp
• src/index/blockfilterindex.h
• src/index/coinstatsindex.cpp
• src/index/coinstatsindex.h
• src/index/spentindex.cpp
• src/index/spentindex.h
• src/index/timestampindex.cpp
• src/index/timestampindex.h
• src/index/txindex.cpp
• src/index/txindex.h
• src/init.cpp
• src/kernel/mempool_limits.h
• src/kernel/mempool_options.h
• src/mempool_args.cpp
• src/node/chainstate.cpp
• src/node/interfaces.cpp
• src/node/mempool_args.cpp
• src/node/mempool_args.h
• src/node/miner.cpp
• src/node/psbt.cpp
• src/policy/policy.cpp
• src/policy/policy.h
• src/policy/settings.cpp
• src/policy/settings.h
• src/qt/guiutil.cpp
• src/rpc/blockchain.cpp
• src/rpc/fees.cpp
• src/rpc/mempool.cpp
• src/rpc/net.cpp
• src/script/standard.cpp
• src/script/standard.h
• src/test/coinstatsindex_tests.cpp
• src/test/evo_assetlocks_tests.cpp
• src/test/evo_deterministicmns_tests.cpp
• src/test/fuzz/integer.cpp
• src/test/fuzz/key.cpp
• src/test/fuzz/partially_downloaded_block.cpp
• src/test/fuzz/policy_estimator.cpp
• src/test/fuzz/script.cpp
• src/test/fuzz/transaction.cpp
• src/test/fuzz/tx_pool.cpp
• src/test/fuzz/util.cpp
• src/test/fuzz/util.h
• src/test/fuzz/util/mempool.cpp
• src/test/fuzz/util/mempool.h
• src/test/fuzz/validation_load_mempool.cpp
• src/test/mempool_tests.cpp
• src/test/multisig_tests.cpp
• src/test/script_p2sh_tests.cpp
• src/test/transaction_tests.cpp
• src/test/txpackage_tests.cpp
• src/test/util/setup_common.cpp
• src/test/util/txmempool.cpp
• src/txmempool.cpp
• src/txmempool.h
• src/util/system.cpp
• src/util/system.h
• src/util/thread.cpp
• src/util/thread.h
• src/validation.cpp
• src/validation.h
• src/wallet/fees.cpp
• src/wallet/test/coinjoin_tests.cpp
• src/wallet/test/wallet_tests.cpp
• test/functional/combine_logs.py

💤 Files with no reviewable changes (12)

• src/index/txindex.h
• src/test/fuzz/util.h
• src/index/addressindex.h
• src/wallet/test/wallet_tests.cpp
• src/index/timestampindex.h
• src/mempool_args.cpp
• src/index/spentindex.h
• src/script/standard.cpp
• src/index/blockfilterindex.h
• src/policy/settings.h
• src/wallet/test/coinjoin_tests.cpp
• src/test/fuzz/util.cpp

🚧 Files skipped from review as they are similar to previous changes (53)

• src/index/blockfilterindex.cpp
• src/wallet/fees.cpp
• src/rpc/net.cpp
• src/test/transaction_tests.cpp
• src/util/system.h
• src/qt/guiutil.cpp
• src/test/evo_deterministicmns_tests.cpp
• src/test/fuzz/validation_load_mempool.cpp
• src/Makefile.test_fuzz.include
• src/test/mempool_tests.cpp
• src/rpc/mempool.cpp
• ci/dash/lint-tidy.sh
• src/test/util/setup_common.cpp
• src/test/multisig_tests.cpp
• src/node/psbt.cpp
• src/util/system.cpp
• src/index/timestampindex.cpp
• src/index/spentindex.cpp
• src/index/coinstatsindex.h
• src/index/addressindex.cpp
• src/util/thread.cpp
• src/index/txindex.cpp
• src/test/txpackage_tests.cpp
• src/kernel/mempool_options.h
• src/node/chainstate.cpp
• src/policy/settings.cpp
• src/policy/policy.h
• src/kernel/mempool_limits.h
• src/rpc/blockchain.cpp
• src/util/thread.h
• src/node/miner.cpp
• src/test/fuzz/script.cpp
• src/test/fuzz/key.cpp
• src/Makefile.am
• src/test/util/txmempool.cpp
• src/policy/policy.cpp
• src/script/standard.h
• src/index/base.h
• src/rpc/fees.cpp
• src/test/fuzz/partially_downloaded_block.cpp
• src/test/fuzz/policy_estimator.cpp
• src/index/coinstatsindex.cpp
• src/test/fuzz/integer.cpp
• src/init.cpp
• src/node/mempool_args.h
• src/txmempool.h
• src/test/fuzz/util/mempool.h
• src/test/fuzz/transaction.cpp
• src/test/coinstatsindex_tests.cpp
• src/txmempool.cpp
• src/node/interfaces.cpp
• src/validation.cpp
• src/validation.h

[coderabbitai]

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail
rg -n -C 6 'GetIntArg|max_size_bytes|ancestor_size_vbytes|descendant_size_vbytes' \
  src/util/system.h src/util/system.cpp \
  src/kernel/mempool_limits.h src/kernel/mempool_options.h

Repository: dashpay/dash

Length of output: 4488

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== Application of affected mempool_args.cpp =="
file=$(fd -a 'mempool_args\.cpp$' . | head -n 1)
echo "$file"
if [ -n "$file" ]; then
  wc -l "$file"
  sed -n '1,90p' "$file" | cat -n
fi

echo
echo "== System parser references =="
sed -n '500,570p' src/util/system.cpp | cat -n
rg -n -C 4 'ParseInt|SettingToInt|GetSetting|SetArg' src/util/system.cpp src/common/ | head -n 120

echo
echo "== mempool options construction callers =="
rg -n -C 5 'ApplyArgsManOptions|mempool_opts|max_size_bytes|ancestor_size_vbytes|descendant_size_vbytes' src node test -g '*.cpp' -g '*.h' | head -n 200

Repository: dashpay/dash

Length of output: 28118

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== LocaleIndependentAtoi implementation =="
rg -n -C 8 'LocaleIndependentAtoi' src util include | head -n 200

echo
echo "== SettingsValue integer/string conversion definitions =="
rg -n -C 8 'class SettingsValue|struct SettingsValue|SettingValue|isNum|get_str|getInt|int64_t|ParseInt' src/util include -g '*.h' -g '*.cpp' | head -n 240

echo
echo "== CTxMemPool construction validation =="
sed -n '1820,1975p' src/init.cpp | cat -n
rg -n -C 6 'CTxMemPool::Options|CTxMemPool\(mempool_opts\)|m_max_size_bytes|Limits::NoLimits' src/txmempool.cpp src/txmempool.h | head -n 220

Repository: dashpay/dash

Length of output: 11780

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== LocaleIndependentAtoi full implementation =="
sed -n '113,180p' src/util/strencodings.h | cat -n

echo
echo "== SettingsValue definition and parsing definitions =="
sed -n '1,140p' src/util/settings.cpp | cat -n
rg -n -C 5 'class SettingsValue|struct SettingsValue|boost::json::value|GetSetting|ParseSettings' src/util src/util -g '*.h' -g '*.cpp' | head -n 220

echo
echo "== MemPoolOptions construction / init validation =="
sed -n '1930,1950p' src/init.cpp | cat -n

echo
echo "== Behavioral probe of C++ int64 multiplication for representative negative/max values =="
python3 - <<'PY'
import ctypes
def wrap64(x):
    return (x & ((1 << 64) - 1)) if x != 0 else 0
cases = [
    (-1, 1_000_000),
    (2_147_483_648, 1_000),
    (9_223_372_036_854_775_808, 1_000),
    (9_223_372_036_854_775_809, 1_000),
]
for a, b in cases:
    res = (a * b) % (1 << 64)
    print(f"{a} * {b} -> {res}")
PY

Repository: dashpay/dash

Length of output: 22420

---

Validate scaled mempool limits before multiplication.

GetIntArg can return negative or clamped boundary values, so these conversions can still overflow or pass invalid mempool limits. Check each parsed limit before multiplying before assignment. Also apply the same check to -maxmempool and avoid treating the saturated negative result as a valid mempool size.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/node/mempool_args.cpp` around lines 32 - 36, Validate parsed values for
-limitancestorsize, -limitdescendantcount, -limitdescendantsize, and -maxmempool
before scaling or assigning them to mempool_limits. Reject negative or
boundary-saturated results before multiplying size values by 1'000, and ensure a
saturated negative -maxmempool value is not accepted as a valid mempool size.

[coderabbitai]

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Handle direct mainnet log paths.

When tmp_dir/node0/debug.log is used, glob('node0/*/debug.log') cannot match it. The code then falls back to regtest, and the later path construction searches for node{i}/regtest/debug.log. This omits mainnet node logs from the combined output. Detect the direct layout separately and use node{i}/debug.log for that mode. Add a regression test for both layouts.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@test/functional/combine_logs.py` around lines 83 - 88, Update the log-path
discovery logic around the existing node0 glob to detect both layouts: direct
mainnet logs at node{i}/debug.log and nested logs at node{i}/<chain>/debug.log.
Preserve the single-match validation, select the corresponding path pattern so
mainnet logs are included instead of falling back to regtest, and add regression
coverage for both layouts.